test_runner: filter execArgv fallback for child tests#64056
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
panva
approved these changes
Jun 22, 2026
72be9b2 to
cf6afe3
Compare
cf6afe3 to
4735216
Compare
Apply the test runner propagation filter to execArgv entries that are not reported by the options binding. This prevents config-file and test-runner flags from leaking into isolated child tests while still preserving V8 flags. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
4735216 to
456353e
Compare
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes flaky failures in
parallel/test-runner-flag-propagation.Apply the test runner propagation filter to
process.execArgventries thatare not reported by the options binding.
Some flags, such as config-file/test-runner flags, can reach the isolated
child test fallback path through
process.execArgv. Without filtering thatpath, flags like
--experimental-config-filemay leak into child tests andre-enable options that should not propagate, including
--experimental-test-coverage.This change keeps preserving V8-only flags such as
--allow-natives-syntax,while filtering test-runner control flags consistently across both
option-binding flags and fallback
execArgventries.Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20is%3Aissue%20state%3Aopen%20%22test-runner-flag-propagation%22
Example
Assisted-by: openai:gpt-5.5