test: use one-off agent in http consumed timeout test#64052
Open
trivikr wants to merge 1 commit into
Open
Conversation
Disable connection pooling for the client request so server.close() does not wait on an idle keep-alive socket before retrying the test. This keeps the test focused on request timeout behavior instead of HTTP keep-alive teardown timing. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
nodejs-github-bot
added
needs-ci
trivikr
added
flaky-test
lpinca
approved these changes
Jun 22, 2026
trivikr
added
the
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
approved these changes
Jun 22, 2026
Collaborator
gurgunday
approved these changes
Jun 22, 2026
Contributor
|
Fast-track has been requested by @trivikr. Please 👍 to approve. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky hang in
parallel/test-http-server-consumed-timeout.The test can retry with a larger timeout when timer intervals are delayed.
That retry is started from the
server.close()callback, but the clientrequest could leave an idle keep-alive socket open. With the current default
server keep-alive timeout,
server.close()can wait long enough for repeatedattempts to hit the test runner timeout.
This changes the client request to use
agent: false, so the connection isnot pooled and
server.close()can complete promptly.Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20is%3Aissue%20state%3Aopen%20%22test-http-server-consumed-timeout%22
Example