Skip to content

tools: exclude libffi changes from test-shared GHA CI#64047

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:libffi-shared
Open

tools: exclude libffi changes from test-shared GHA CI#64047
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:libffi-shared

Conversation

@aduh95

@aduh95 aduh95 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

libffi directory is not included in the tarball the workflow is using:

node/Makefile

Line 1304 in b8d1e4e

$(RM) -r $(TARNAME)/deps/libffi

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 21, 2026
@Renegade334 Renegade334 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 21, 2026
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants