doc: remove duplicated sentences in large-pull-requests.md#63650
Merged
Conversation
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Collaborator
|
Review requested:
|
panva
approved these changes
May 29, 2026
This comment was marked as off-topic.
This comment was marked as off-topic.
RafaelGSS
approved these changes
May 29, 2026
joyeecheung
added
the
fast-track
Contributor
|
Fast-track has been requested by @joyeecheung. Please 👍 to approve. |
tniessen
approved these changes
May 29, 2026
mertcanaltin
approved these changes
May 29, 2026
trivikr
approved these changes
May 30, 2026
mcollina
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63650 ✔ Done loading data for nodejs/node/pull/63650 ----------------------------------- PR info ------------------------------------ Title doc: remove duplicated sentences in large-pull-requests.md (#63650) Author Joyee Cheung <joyeec9h3@gmail.com> (@joyeecheung) Branch joyeecheung:large-pr-fix -> nodejs:main Labels doc, fast-track Commits 1 - doc: remove duplicated sentences in large-pull-requests.md Committers 1 - Joyee Cheung <joyeec9h3@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63650 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63650 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 29 May 2026 18:39:30 GMT ✔ Approvals: 5 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/63650#pullrequestreview-4392009190 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/63650#pullrequestreview-4392303617 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63650#pullrequestreview-4392832022 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/63650#pullrequestreview-4393021742 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/63650#pullrequestreview-4394197948 ℹ This PR is being fast-tracked ✘ This PR needs to wait 35 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/26678843884 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 80e5174 |
aduh95
pushed a commit
that referenced
this pull request
May 30, 2026
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com> PR-URL: #63650 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it probably came from bugs in the GitHub suggestion UI..(funny enough, the duplicated sentences are also citing issues in the GitHub UI 😅)