Skip to content

build: remove duplicated node_use_sqlite and node_use_ffi conditions#63629

Open
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:node-gyp-cleanup
Open

build: remove duplicated node_use_sqlite and node_use_ffi conditions#63629
legendecas wants to merge 1 commit into
nodejs:mainfrom
legendecas:node-gyp-cleanup

Conversation

@legendecas
Copy link
Copy Markdown
Member

node/node.gyp

Lines 1012 to 1028 in e1ae3a5

[ 'node_use_sqlite=="true"', {
'sources': [
'<@(node_sqlite_sources)',
],
}],
[ 'node_use_ffi=="true"', {
'sources': [
'<@(node_ffi_sources)',
],
'conditions': [
[ 'node_shared_ffi=="false"', {
'dependencies': [
'deps/libffi/libffi.gyp:libffi',
],
}],
],
}],
are duplicated with

node/node.gyp

Lines 1074 to 1090 in e1ae3a5

[ 'node_use_sqlite=="true"', {
'sources': [
'<@(node_sqlite_sources)',
],
}],
[ 'node_use_ffi=="true"', {
'sources': [
'<@(node_ffi_sources)',
],
'conditions': [
[ 'node_shared_ffi=="false"', {
'dependencies': [
'deps/libffi/libffi.gyp:libffi',
],
}],
],
}],
in the same target.

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels May 28, 2026
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 29, 2026
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2026
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. commit-queue Add this label to land a pull request using GitHub Actions. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants