build: build codecache and snapshot with libnode#63626
Open
legendecas wants to merge 4 commits into
Open
Conversation
Collaborator
|
Review requested:
|
adf769d to
fac4309
Compare
Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net>
fac4309 to
e880392
Compare
joyeecheung
approved these changes
May 28, 2026
Member
joyeecheung
left a comment
There was a problem hiding this comment.
Thanks. LGTM if CI is happy!
| else: | ||
| o['variables']['node_use_node_snapshot'] = b( | ||
| not cross_compiling and not options.shared) | ||
| o['variables']['node_use_node_snapshot'] = b(not cross_compiling) |
Member
There was a problem hiding this comment.
Non-blocking but a couple of lines above, there's also another guard that errors out on --shared for node_snapshot_main, which I think is also fixed by this PR and can be removed?
Member
Author
There was a problem hiding this comment.
Technically yeah, but I haven't tested with node_snapshot_main. Will give it a shot.
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the
nodeandlibnodetargets, splitting thenode_mksnapshotaction from thenodeexe target, and adding a (always) staticnode_basetarget, allowinglibnodeto depend onnode_mksnapshotexe, enabling the node startup snapshot when building with flag--shared.The new dependency graph would be like: