quic: convert incoming :status header to number#63589
Open
hallss93 wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Qard
approved these changes
May 28, 2026
pimterry
approved these changes
May 28, 2026
Member
|
@hallss93 Looks like the commit message here is failing the linting as it's not signed off, you'll need to update that with |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63589 +/- ##
==========================================
+ Coverage 90.31% 90.32% +0.01%
==========================================
Files 730 730
Lines 234653 234658 +5
Branches 43952 43951 -1
==========================================
+ Hits 211926 211959 +33
+ Misses 14474 14430 -44
- Partials 8253 8269 +16
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #63557
Summary
When receiving HTTP/3 headers via QUIC,
headers[':status']was exposed as astring. HTTP/2 converts the incoming
:statuspseudo-header to a number intoHeaderObject()(lib/internal/http2/util.js). This mismatch makes itawkward to port HTTP/2 code to HTTP/3.
Align HTTP/3 with HTTP/2 by converting
:statusto a number inparseHeaderPairs()when building the header object from C++ name/valuepairs. This applies to initial response headers, informational (
1xx)headers (
oninfo), andstream.headers.Outgoing headers are unchanged: callers may still pass
':status': '200'or':status': 200when callingsendHeaders()/sendInformationalHeaders().Test plan
Update existing QUIC H3 tests to expect numeric
:statuson receiveAdd
test/parallel/test-quic-h3-status-code-type.mjscovering 200, 204, and 404Run (with QUIC enabled):