[canary-base] test: update for new V8 serialization format#63475
Open
joyeecheung wants to merge 1 commit into
Open
[canary-base] test: update for new V8 serialization format#63475joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
joyeecheung
commented
May 21, 2026
| `; | ||
|
|
||
| const desStr = 'ff0f6f2203666f6f5e007b01'; | ||
| const desStr = 'ff106f2203666f6f5e007b01'; |
Member
Author
There was a problem hiding this comment.
I figured it might be worth it to keep this one as a semver-major signal, as the message above indicates. But on a side note this might be worth to fold into nodejs/TSC#1852 as well..
V8 bumped its wire-format version from 0x0f to 0x10. Update the expected hex in test-v8-serdes, and derive the v8 header bytes dynamically in test-runner-v8-deserializer so it tracks future bumps automatically. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Member
|
Just a side note... these version bumps can be a bit problematic for folks who use the serialization api to store persistently to disk. In Workers we have a patch to allow the version to be set explicitly for both deserialization and serialization. We haven't yet tried to upstream them but we certainly could. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V8 bumped its wire-format version from 0x0f to 0x10. Update the expected hex in test-v8-serdes, and derive the v8 header bytes dynamically in test-runner-v8-deserializer so it tracks future bumps automatically.
Fixes: nodejs/node-v8#311