benchmark: respect stream/iter broadcast backpressure#63314
Open
trivikr wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
Only decrement the remaining byte count after a stream/iter broadcast write is accepted. If writeSync() is blocked by strict backpressure, fall back to the async write() path for the same chunk. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-throughput-broadcast
branch
from
1da5fa8 to
88ee786
Compare
trivikr
changed the title
jasnell
approved these changes
May 15, 2026
trivikr
added
author ready
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63314 ✔ Done loading data for nodejs/node/pull/63314 ----------------------------------- PR info ------------------------------------ Title benchmark: respect stream/iter broadcast backpressure (#63314) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch trivikr:stream-iter-throughput-broadcast -> nodejs:main Labels stream, benchmark, author ready Commits 1 - benchmark: respect stream/iter broadcast backpressure Committers 1 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/63314 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63314 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 15 May 2026 01:05:45 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63314#pullrequestreview-4298652803 ✘ This PR needs to wait 120 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/25977767540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
stream/iterbroadcast throughput benchmark to respectbackpressure from
writer.writeSync().Previously, the benchmark decremented
remainingbefore checking whetherwriteSync()accepted the chunk. Under default strict backpressure, rejectedwrites could still be counted toward the benchmarked byte total. The iter path
now falls back to
await writer.write(buf)for the same chunk and only counts itafter the write is accepted.
Assisted-by: openai:gpt-5.5