quic: apply multiple quic performance and packet handling improvements

[jasnell]

A number of planned backend changes and improvements in the packet handling. Yields a net performance improvement of around 10% higher rps. Sets us up to be able to better leverage libuv/libuv#5116 if/when that lands (@santigimeno @saghul fyi) which will provide an even larger perf boost. Fixes a bug while we're at it.

@nodejs/quic

[nodejs-github-bot]

Review requested:

• @nodejs/quic

[codecov]

Codecov Report

❌ Patch coverage is 99.55605% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.08%. Comparing base (2d6cbea) to head (fdef9eb).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/fs/promises.js	66.66%	2 Missing ⚠️
src/dataqueue/queue.cc	60.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #63267      +/-   ##
==========================================
+ Coverage   90.06%   90.08%   +0.01%     
==========================================
  Files         714      714              
  Lines      225502   225988     +486     
  Branches    42628    42635       +7     
==========================================
+ Hits       203089   203570     +481     
+ Misses      14195    14192       -3     
- Partials     8218     8226       +8     

Files with missing lines	Coverage Δ
lib/internal/quic/quic.js	100.00% <ø> (ø)
lib/internal/quic/state.js	100.00% <100.00%> (ø)
lib/internal/quic/stats.js	100.00% <100.00%> (ø)
lib/internal/quic/symbols.js	100.00% <ø> (ø)
src/aliased_struct-inl.h	90.90% <ø> (ø)
src/aliased_struct.h	100.00% <ø> (ø)
lib/internal/fs/promises.js	92.87% <66.66%> (-0.08%)	⬇️
src/dataqueue/queue.cc	67.56% <60.00%> (-0.08%)	⬇️

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Ethan-Arrowood]

This diff is quite large. Can you provide a short summary of the most relevant parts? Such as maybe notable performance improvement areas, the bug fix, and whatever else seems relevant. That'll help expedite reviews, thanks!

[jasnell]

Just an idea of where we're at... running a local 'hello world' benchmark using h2load as the client driver on the same 88 core machine... 4 runs with 100,000 requests over 100 concurrent connections:

The rps is not as high as I'd like and http/1 still beats it by a long way but it's a solid result for current state.

The primary performance bottleneck right now is the JS side, GC, and the C++/JS boundary cross. We lose a fair amount of throughput in the context switching.

My current goal is to get the per-request down to 10 microseconds.

[jasnell]

Ok, with a bit of perf tunning and mangling with both h2load options and v8 perf tuning options on the server, with a node binary built with pointer compression enabled... we can get ~101k-102k rps. Still slower than http/1, on par with http/2 when pointer compression is enabled. Overall a great result given that I've only just started the perf tuning of the implementation.

/tmp/opencode/local/bin/h2load --h3 -n 200000 -c 5 -w 26 -W 30 -m 10 -D 2 https://127.0.0.1:4433
starting benchmark...
spawning thread #0: 5 total client(s). Timing-based test with 0s of warm-up time and 2s of main duration for measurements.
Warm-up started for thread #0.
progress: 20% of clients started
progress: 40% of clients started
progress: 60% of clients started
progress: 80% of clients started
progress: 100% of clients started
Warm-up phase is over for thread #0.
Main benchmark duration is started for thread #0.
TLS Protocol: TLSv1.3
Cipher: TLS_AES_128_GCM_SHA256
Certificate: ECDSA P-256 256 bits
Negotiated Group: X25519
Resumption: no
Application protocol: h3
Main benchmark duration is over for thread #0. Stopping all clients.
Stopped all clients for thread #0

finished in 2.02s, 102130.00 req/s, 2.23MB/s
requests: 204260 total, 204310 started, 204260 done, 204260 succeeded, 0 failed, 0 errored, 0 timeout
status codes: 204260 2xx, 0 3xx, 0 4xx, 0 5xx
traffic: 4.46MB (4676960) total, 797.97KB (817120) headers (space savings 87.50%), 2.14MB (2247080) data
UDP datagram: 33273 sent, 20462 received
                 min         max         median      p95         p99         mean        sd         +/- sd
request     :      150us     53.98ms       435us       490us       813us       487us      1.28ms    99.59%
connect     :     4.89ms      5.64ms      5.30ms      5.64ms      5.64ms      5.28ms       295us    60.00%
TTFB        :     8.11ms      8.25ms      8.18ms      8.25ms      8.25ms      8.18ms        54us    60.00%
req/s       :   20402.15    20442.34    20417.92    20442.34    20442.34    20421.97       17.40    60.00%
min RTT     :       22us       115us        38us       115us       115us        57us        40us    80.00%
smoothed RTT:       86us       226us       164us       226us       226us       163us        60us    60.00%
packets sent:       6219        7436        6373        7436        7436     6656.60      545.25    80.00%
packets recv:       4092        4099        4092        4099        4099     4094.40        3.36    80.00%
packets lost:          0           0           0           0           0        0.00        0.00   100.00%
GRO packets :          1           1           1           1           1        1.00        0.00   100.00%