test_runner: make skip/todo/expectFailure use JS truthiness#62346
Open
VaishnavIUpadyaya wants to merge 3 commits intonodejs:mainfrom
Open
test_runner: make skip/todo/expectFailure use JS truthiness#62346VaishnavIUpadyaya wants to merge 3 commits intonodejs:mainfrom
VaishnavIUpadyaya wants to merge 3 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
atlowChemi
reviewed
Mar 20, 2026
Comment on lines
+7
to
+15
| let ran = false; | ||
|
|
||
| test('skip option empty string should not skip', { skip: '' }, () => { | ||
| ran = true; | ||
| }); | ||
|
|
||
| process.on('exit', () => { | ||
| assert.ok(ran); | ||
| }); |
Member
There was a problem hiding this comment.
I think this should be something around the lines of:
test('skip option empty string should not skip', { skip: '' }, mustCall());
using mustCall from common
Author
There was a problem hiding this comment.
Thanks! Updated to use common.mustCall().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61815
Updates skip, todo, and expectFailure handling in the test runner
to use JavaScript truthiness instead of explicit undefined/false checks.
This ensures:
Adds a test to verify that skip: '' does not skip the test.