url: optimize URLSearchParams set/delete duplicate handling

[gurgunday]

This changes set and delete to use a single pass instead of repeated array.splice() while scanning

master:

url/url-searchparams-mutation.js n=10000 count=10 type="unique" method="set": 4,495,307.348658735
url/url-searchparams-mutation.js n=10000 count=1000 type="unique" method="set": 397,595.2168977331
> url/url-searchparams-mutation.js n=10000 count=10 type="duplicates" method="set": 2,309,513.092283293
> url/url-searchparams-mutation.js n=10000 count=1000 type="duplicates" method="set": 7,585.0868936063125
url/url-searchparams-mutation.js n=10000 count=10 type="unique" method="delete": 4,530,011.325028313
url/url-searchparams-mutation.js n=10000 count=1000 type="unique" method="delete": 305,692.37412161205
> url/url-searchparams-mutation.js n=10000 count=10 type="duplicates" method="delete": 2,222,098.772290428
> url/url-searchparams-mutation.js n=10000 count=1000 type="duplicates" method="delete": 7,601.665867066438

branch:

url/url-searchparams-mutation.js n=10000 count=10 type="unique" method="set": 4,314,296.500026965
url/url-searchparams-mutation.js n=10000 count=1000 type="unique" method="set": 398,303.2282476649
> url/url-searchparams-mutation.js n=10000 count=10 type="duplicates" method="set": 4,662,911.158019998
> url/url-searchparams-mutation.js n=10000 count=1000 type="duplicates" method="set": 199,327.60023302992
url/url-searchparams-mutation.js n=10000 count=10 type="unique" method="delete": 4,569,515.119611628
url/url-searchparams-mutation.js n=10000 count=1000 type="unique" method="delete": 284,133.96507300285
> url/url-searchparams-mutation.js n=10000 count=10 type="duplicates" method="delete": 5,081,732.037220638
> url/url-searchparams-mutation.js n=10000 count=1000 type="duplicates" method="delete": 213,852.28153652867

[nodejs-github-bot]

Review requested:

• @nodejs/performance
• @nodejs/url

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (8ccbe8e) to head (d8ceae6).
⚠️ Report is 45 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #62266      +/-   ##
==========================================
- Coverage   89.68%   89.68%   -0.01%     
==========================================
  Files         676      676              
  Lines      206495   206714     +219     
  Branches    39537    39583      +46     
==========================================
+ Hits       185204   185393     +189     
- Misses      13435    13446      +11     
- Partials     7856     7875      +19     

Files with missing lines	Coverage Δ
lib/internal/url.js	93.17% <100.00%> (+0.02%)	⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mertcanaltin]

lgtm

[H4ad]

@gurgunday can we split this PR in two, so we can have benchmark introduced first and then the improvements? Or maybe split in two commits, then we can try use the benchmark commit as base to test the improvements on our CI.

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1812/

Results

confidence improvement accuracy (*)    (**)   (***)
url/url-searchparams-mutation.js n=10000 count=10 type='duplicates' method='delete'          ***     85.65 %      ±14.99% ±20.10% ±26.47%
url/url-searchparams-mutation.js n=10000 count=10 type='duplicates' method='set'             ***     89.29 %      ±21.64% ±28.90% ±37.83%
url/url-searchparams-mutation.js n=10000 count=10 type='unique' method='delete'                       1.32 %      ±10.72% ±14.27% ±18.57%
url/url-searchparams-mutation.js n=10000 count=10 type='unique' method='set'                         -7.06 %      ±12.09% ±16.09% ±20.95%
url/url-searchparams-mutation.js n=10000 count=1000 type='duplicates' method='delete'        ***   1852.47 %      ±17.99% ±24.23% ±32.15%
url/url-searchparams-mutation.js n=10000 count=1000 type='duplicates' method='set'           ***   1552.29 %      ±13.02% ±17.53% ±23.25%
url/url-searchparams-mutation.js n=10000 count=1000 type='unique' method='delete'            ***    -23.32 %       ±1.79%  ±2.39%  ±3.14%
url/url-searchparams-mutation.js n=10000 count=1000 type='unique' method='set'                        1.40 %       ±2.03%  ±2.71%  ±3.53%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 8 comparisons, you can thus
expect the following amount of false-positive results:
  0.40 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.08 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

[aduh95]

What's the point of declaring a variable we use once?

nit:

Suggested change

	const len = list.length;
	const { length } = list;

[gurgunday]

it's a habit of mine from the days when hoisting the length before for loops was faster

i can remove it if you'd like, but i applied your suggestion

[gurgunday]

and we do access it one more time later :)

[mcollina]

lgtm