Skip to content

build: fix --node-builtin-modules-path#62115

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:issues-node-builtin-modules-path
Open

build: fix --node-builtin-modules-path#62115
panva wants to merge 1 commit intonodejs:mainfrom
panva:issues-node-builtin-modules-path

Conversation

@panva
Copy link
Member

@panva panva commented Mar 5, 2026

Disclaimer: I am way out of my depth here and am more than happy to pawn this off to someone who's not. The following stopped working for me some time back in that it no longer picks up js changes without re-make.

./configure --node-builtin-modules-path $(pwd) --ninja 
make

I threw Claude at the problem and it came up with this which fixed the issue for me. I'm opening this as a draft so hopefully other collaborators with more insight into how this works can chime in and verify whether there is something awry or not.

Darwin M1-MacBook-Pro.local 25.3.0 Darwin Kernel Version 25.3.0: Wed Jan 28 20:53:15 PST 2026; root:xnu-12377.81.4~5/RELEASE_ARM64_T6000 arm64

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 5, 2026
@panva
Copy link
Member Author

panva commented Mar 5, 2026

@joyeecheung I can now confirm the breaking point was #60518 (12fad1b).

@panva panva force-pushed the issues-node-builtin-modules-path branch from 410b8e7 to 22be1a2 Compare March 5, 2026 16:02
@panva panva marked this pull request as ready for review March 5, 2026 16:02
@panva panva requested a review from joyeecheung March 5, 2026 16:02
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.58%. Comparing base (330e3ee) to head (22be1a2).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/node_builtins.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62115      +/-   ##
==========================================
- Coverage   91.62%   89.58%   -2.05%     
==========================================
  Files         337      676     +339     
  Lines      140453   206173   +65720     
  Branches    21801    39446   +17645     
==========================================
+ Hits       128694   184697   +56003     
- Misses      11536    13595    +2059     
- Partials      223     7881    +7658     
Files with missing lines Coverage Δ
src/node_builtins.cc 75.90% <0.00%> (ø)

... and 459 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants