test_runner: print failed coverage reports with dot reporter fixes #60884#62091
Open
KJyang-0114 wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: print failed coverage reports with dot reporter fixes #60884#62091KJyang-0114 wants to merge 1 commit intonodejs:mainfrom
KJyang-0114 wants to merge 1 commit intonodejs:mainfrom
Conversation
When coverage threshold is not met, the dot reporter now outputs the error message so users can understand why tests failed. Refs: nodejs#60884
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When coverage threshold is not met, the dot reporter now outputs the error message so users can understand why tests failed.
Problem
When running tests with both the dot reporter and coverage reports, if the coverage report fails there is no output (other than the dots) but the program exits with a failure status code.
Solution
Similar to PR #52655, this adds support for the
test:diagnosticevent type in the dot reporter. When coverage threshold is not met, the error message will now be displayed.Changes
test:diagnosticevent type in dot reporterRefs: #60884