Skip to content

Comments

tools: switch to ARM runners for coverage-linux-without-intl.yml#61945

Open
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:ubuntu-arm
Open

tools: switch to ARM runners for coverage-linux-without-intl.yml#61945
aduh95 wants to merge 1 commit intonodejs:mainfrom
aduh95:ubuntu-arm

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 22, 2026

Not included in #61903 but we still want this.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Feb 22, 2026
@targos
Copy link
Member

targos commented Feb 23, 2026

Coverage dropped because of cctest failures (so JS tests didn't run):

2026-02-22T23:22:37.7640122Z ../test/cctest/test_traced_value.cc:83: Failure
2026-02-22T23:22:37.7640412Z Expected equality of these values:
2026-02-22T23:22:37.7640609Z   check
2026-02-22T23:22:37.7640823Z     Which is: "{\"a\":\"1\\u00E2\\u0082\\u00AC23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"}"
2026-02-22T23:22:37.7641107Z   string
2026-02-22T23:22:37.7641306Z     Which is: "{\"a\":\"1\xE2\x82\xAC" "23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"}"
2026-02-22T23:22:37.7641889Z     As Text: "{"a":"1€23\"\u0001\b\f\n\r\t\\"}"
2026-02-22T23:22:37.7642106Z With diff:
2026-02-22T23:22:37.7642271Z @@ -1 +1,2 @@
2026-02-22T23:22:37.7642477Z -{\"a\":\"1\\u00E2\\u0082\\u00AC23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"}
2026-02-22T23:22:37.7642773Z +{\"a\":\"1\xE2\x82\xAC" "23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"}"
2026-02-22T23:22:37.7643071Z     As Text: "{"a":"1€23\"\u0001\b\f
2026-02-22T23:22:37.7643261Z +\r\t\\"}
2026-02-22T23:22:37.7643341Z 
2026-02-22T23:22:37.7643345Z 
2026-02-22T23:22:37.7643444Z [  FAILED  ] TracedValue.EscapingObject (0 ms)
2026-02-22T23:22:37.7643705Z [ RUN      ] TracedValue.EscapingArray
2026-02-22T23:22:37.7643946Z ../test/cctest/test_traced_value.cc:95: Failure
2026-02-22T23:22:37.7644187Z Expected equality of these values:
2026-02-22T23:22:37.7644376Z   check
2026-02-22T23:22:37.7644577Z     Which is: "[\"1\\u00E2\\u0082\\u00AC23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"]"
2026-02-22T23:22:37.7644843Z   string
2026-02-22T23:22:37.7645037Z     Which is: "[\"1\xE2\x82\xAC" "23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"]"
2026-02-22T23:22:37.7645393Z     As Text: "["1€23\"\u0001\b\f\n\r\t\\"]"
2026-02-22T23:22:37.7645601Z With diff:
2026-02-22T23:22:37.7645727Z @@ -1 +1,2 @@
2026-02-22T23:22:37.7645915Z -[\"1\\u00E2\\u0082\\u00AC23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"]
2026-02-22T23:22:37.7646673Z +[\"1\xE2\x82\xAC" "23\\\"\\u0001\\b\\f\\n\\r\\t\\\\\"]"
2026-02-22T23:22:37.7647018Z     As Text: "["1€23\"\u0001\b\f
2026-02-22T23:22:37.7647196Z +\r\t\\"]
2026-02-22T23:22:37.7647274Z 
2026-02-22T23:22:37.7647280Z 
2026-02-22T23:22:37.7647381Z [  FAILED  ] TracedValue.EscapingArray (0 ms)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants