test_runner: skip branches entirely on ignored lines#61845
Open
drtootsie wants to merge 1 commit intonodejs:mainfrom
Open
test_runner: skip branches entirely on ignored lines#61845drtootsie wants to merge 1 commit intonodejs:mainfrom
drtootsie wants to merge 1 commit intonodejs:mainfrom
Conversation
Fixes: nodejs#61586 When a branch is entirely on ignored lines (via c8 ignore comments), it should not appear in the BRDA output at all, rather than appearing with 0 coverage. Modified the branch coverage logic to check if all lines in the branch are ignored before adding to branchReports and incrementing totalBranches. This ensures ignored branches don't pollute coverage reports.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
pmarchini
reviewed
Feb 16, 2026
| range.ignoredLines === range.lines.length) { | ||
| branchesCovered++; | ||
| // Skip branches that are entirely on ignored lines | ||
| if (range.ignoredLines !== range.lines.length) { |
Member
There was a problem hiding this comment.
Could you please cover these changes with tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #61586
Summary
When a branch is entirely on ignored lines (via c8 ignore comments), it should not appear in the BRDA output at all, rather than appearing with 0 coverage.
Changes
Modified the branch coverage logic in
lib/internal/test_runner/coverage.jsto check if all lines in the branch are ignored before:branchReportsarraytotalBranchescounterThis ensures ignored branches don't pollute coverage reports.
Testing
Requires building Node.js and running the test suite:
./configure && make -j4 make test-only