-
-
Notifications
You must be signed in to change notification settings - Fork 34.8k
lib: include ESM loader in the built-in snapshot #61769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joyeecheung
wants to merge
6
commits into
nodejs:main
Choose a base branch
from
joyeecheung:esm-in-snapshot
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+126
−130
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
fa8161a
test: allow filtering async internal frames in assertSnapshot
joyeecheung 92d6e40
lib: remove top-level getOptionValue() calls in lib/internal/modules
joyeecheung d00eeec
lib: reduce cycles in esm loader and load it in snapshot
joyeecheung 9cd87a2
benchmark: add startup benchmark for ESM entrypoint
joyeecheung f33117a
fixup! test: allow filtering async internal frames in assertSnapshot
joyeecheung 21bdb3d
fixup! test: allow filtering async internal frames in assertSnapshot
joyeecheung File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import 'node:async_hooks'; | ||
| import 'node:assert'; | ||
| import 'node:buffer'; | ||
| import 'node:child_process'; | ||
| import 'node:console'; | ||
| import 'node:constants'; | ||
| import 'node:crypto'; | ||
| import 'node:cluster'; | ||
| import 'node:dgram'; | ||
| import 'node:dns'; | ||
| import 'node:domain'; | ||
| import 'node:events'; | ||
| import 'node:fs'; | ||
| import 'node:http'; | ||
| import 'node:http2'; | ||
| import 'node:https'; | ||
| import 'node:module'; | ||
| import 'node:net'; | ||
| import 'node:os'; | ||
| import 'node:path'; | ||
| import 'node:perf_hooks'; | ||
| import 'node:process'; | ||
| import 'node:querystring'; | ||
| import 'node:readline'; | ||
| import 'node:repl'; | ||
| import 'node:stream'; | ||
| import 'node:string_decoder'; | ||
| import 'node:timers'; | ||
| import 'node:tls'; | ||
| import 'node:tty'; | ||
| import 'node:url'; | ||
| import 'node:util'; | ||
| import 'node:vm'; | ||
| import 'node:zlib'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
node:sqliteomitted intentionally from here?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's copied from the require-builtins which predated sqlite. Can update both in a follow up (I think there are probably a few other newer builtins not included too).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if there could be a new lint rule just to keep these 2 files up to date at all times? I'm not knowledgeable enough in ESLint to implement this, but maybe it is a viable path to ensure these files do not get left behind as builtins change (added, removed, renamed) over time.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO a lint rule is a bit of an overkill - that kind of put the pressure on anyone who adds a new built-in to run the benchmark and measure its loading performance when that's not really a universally important metrics for all builtins. For builtins that are changed or removed we have already smoking benchmark tests to ensure these benchmarks don't throw.