build,win: add WinGet Visual Studio 2022 Build Tools Edition config#61652
Open
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
Open
build,win: add WinGet Visual Studio 2022 Build Tools Edition config#61652MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
MikeMcC399 wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
build
MikeMcC399
force-pushed
the
visual-studio-2022-winget-add-build-tools
branch
from
2156d16 to
77cc845
Compare
Contributor
Author
Contributor
Author
|
I would plan to follow up this PR with another one that adds DSC configurations for Visual Studio 2026. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current situation
BUILDING > Windows > Option 2: Automated install with WinGet contains instructions to install Node.js build prerequisites using predefined .configurations for Visual Studio 2022 on Windows:
Compared to both the sections Option 1: Manual install and Option 3: Automated install with Boxstarter, a WinGet configuration for the Visual Studio 2022 Build Tools Edition for Option 2 is missing. The documentation is also slightly misleading, since it lists "Visual Studio 2022 Build Tools" as being installed, although this edition is not installed.
Change
Add a Build Tools 2022 Edition configuration to the .configurations directory:
configuration.vsBuildTools.dsc.yamlThe required Desktop develop development with C++ workload has
ID: Microsoft.VisualStudio.Workload.VCTools, differing from other editions such as the Community Edition which uses instead ID: Microsoft.VisualStudio.Workload.NativeDesktop.Align workload naming to the Visual Studio Installer UI and documentation, changing "Visual C++" to "Desktop development with C++" workload.
Use relative links to ensure the document points to its own branch and not just the
mainbranch