Skip to content

Comments

[v22.x] doc: supported toolchain with Visual Studio 2022 only#61451

Merged
aduh95 merged 1 commit intonodejs:v22.x-stagingfrom
MikeMcC399:v22.x-visual-studio-2022
Feb 23, 2026
Merged

[v22.x] doc: supported toolchain with Visual Studio 2022 only#61451
aduh95 merged 1 commit intonodejs:v22.x-stagingfrom
MikeMcC399:v22.x-visual-studio-2022

Conversation

@MikeMcC399
Copy link
Contributor

@MikeMcC399 MikeMcC399 commented Jan 20, 2026

Refs: #60869
Refs: #61449

Situation

The Supported toolchains section for v22.x lists Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host.

By implication, this includes also the latest release of Microsoft Visual Studio which is Visual Studio 2026.

.\vcbuild fails to run in the v22.x branch on Windows 11 25H2 in a PowerShell terminal with the Windows Prerequisites installed, with only Visual Studio Build Tools 2026 installed.

Support for Visual Studio Build Tools 2026 requires a minimum of gyp-next@0.21.0.

The Node.js v22.x branch includes gyp-next@0.20.4 in v22.x/tools/gyp and so lacks support for Visual Studio 2026.

Failure log

.\vcbuild
Looking for Python
Python found in C:\Users\mikem\AppData\Local\Microsoft\WindowsApps\\python.exe
Python 3.14.2
Looking for NASM
Looking for Visual Studio 2022
Failed to find a suitable Visual Studio installation.
Try to run in a "Developer Command Prompt" or consult
https://github.com/nodejs/node/blob/HEAD/BUILDING.md#windows

Change

In BUILDING.md

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/build
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Jan 20, 2026
@MikeMcC399 MikeMcC399 changed the title [v22.x] doc: support toolchain with Visual Studio 2022 only [v22.x] doc: supported toolchain with Visual Studio 2022 only Jan 20, 2026
@MikeMcC399 MikeMcC399 marked this pull request as ready for review January 20, 2026 12:40
@MikeMcC399 MikeMcC399 force-pushed the v22.x-visual-studio-2022 branch from 7ba4b81 to 8b36fec Compare February 23, 2026 09:33
@MikeMcC399
Copy link
Contributor Author

Rebased on current v22.x-staging

This should be a candidate for inclusion into #61947.

The current documentation section v22.x : BUILDING > Supported toolchains is incorrect for Windows.

@aduh95 aduh95 removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 23, 2026
@aduh95 aduh95 merged commit aa31bed into nodejs:v22.x-staging Feb 23, 2026
14 checks passed
@aduh95
Copy link
Contributor

aduh95 commented Feb 23, 2026

Landed in aa31bed

@MikeMcC399 MikeMcC399 deleted the v22.x-visual-studio-2022 branch February 23, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants