repl: remove dependency on domain module by mcollina · Pull Request #61227 · nodejs/node

mcollina · 2025-12-30T21:02:08Z

Replace domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes REPL's dependency on the deprecated domain module while preserving existing behavior and allowing the domain module to still be used within REPL sessions.

Changes

Use AsyncLocalStorage to track REPL instance context
Add addUncaughtExceptionCaptureCallback API for auxiliary callbacks, allowing REPL and domain to coexist
REPL checks for active domain before handling errors locally
Remove mutual exclusivity between domain and setUncaughtExceptionCaptureCallback

Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: nodejs#61227

codecov · 2026-01-10T11:52:37Z

Codecov Report

❌ Patch coverage is 94.89362% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (1647288) to head (f80a221).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/repl.js	94.53%	10 Missing ⚠️
lib/internal/process/execution.js	95.74%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61227      +/-   ##
==========================================
+ Coverage   89.64%   89.66%   +0.01%     
==========================================
  Files         676      676              
  Lines      206330   206390      +60     
  Branches    39518    39531      +13     
==========================================
+ Hits       184973   185052      +79     
+ Misses      13480    13464      -16     
+ Partials     7877     7874       -3

Files with missing lines	Coverage Δ
lib/domain.js	`98.33% <100.00%> (-0.05%)`	⬇️
lib/internal/bootstrap/node.js	`98.96% <100.00%> (+<0.01%)`	⬆️
lib/internal/process/execution.js	`94.55% <95.74%> (+0.37%)`	⬆️
lib/repl.js	`93.95% <94.53%> (-0.25%)`	⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

mcollina · 2026-01-10T21:24:13Z

@nodejs/tsc this needs more reviews

aduh95 · 2026-01-10T22:28:29Z

There are linter and test failures to address

Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: nodejs#61227

mcollina · 2026-01-11T17:51:57Z

@aduh95 done

github-actions · 2026-01-12T09:01:00Z

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - repl: remove dependency on domain module
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/20913460585

marco-ippolito

LGTM with green CI

mcollina · 2026-01-13T21:44:28Z

I’ve updated this PR and made it minor by adding a new API and make it backward compatible with using domain.

I would wait for backporting this.

Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: nodejs#61227

RafaelGSS · 2026-02-07T20:14:33Z

doc/api/process.md

+```mjs
+import process from 'node:process';
+
+process.addUncaughtExceptionCaptureCallback((err) => {


Won't it be available on global process?

RafaelGSS · 2026-02-07T20:14:47Z

doc/api/process.md


 This feature is not available in [`Worker`][] threads.

+## `process.addUncaughtExceptionCaptureCallback(fn)`


Should we land it as experimental first?

RafaelGSS · 2026-02-07T20:15:33Z

doc/api/process.md

 method with a non-`null` argument while another capture function is set will
 throw an error.

-Using this function is mutually exclusive with using the deprecated


I guess we should add this to changes: at the top of this function documentation

RafaelGSS · 2026-02-07T20:16:25Z

lib/internal/process/execution.js

+// Otherwise, the primary callback (if set) is called.
+function addUncaughtExceptionCaptureCallback(fn) {
+  if (typeof fn !== 'function') {
+    throw new ERR_INVALID_ARG_TYPE('fn', 'Function', fn);


Suggested change

throw new ERR_INVALID_ARG_TYPE('fn', 'Function', fn);

validateFunction(fn, 'fn');

mcollina · 2026-02-09T23:04:10Z

@RafaelGSS ping

nodejs-github-bot · 2026-02-10T14:04:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71290/

nodejs-github-bot · 2026-02-13T23:36:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71338/

nodejs-github-bot · 2026-02-14T17:23:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71341/

avivkeller · 2026-02-26T20:55:46Z

@mcollina conflicts

Replace the domain-based error handling with AsyncLocalStorage and setUncaughtExceptionCaptureCallback. This removes the REPL's dependency on the deprecated domain module while preserving all existing behavior: - Synchronous errors during eval are caught and displayed - Async errors (setTimeout, promises, etc.) are caught via the uncaught exception capture callback - Top-level await errors are caught and displayed - The REPL continues operating after errors - Multiple REPL instances can coexist with errors routed correctly Changes: - Use AsyncLocalStorage to track which REPL instance owns an async context, replacing domain's automatic async tracking - Add setupExceptionCapture() to install setUncaughtExceptionCaptureCallback for catching async errors and routing them to the correct REPL - Extract error handling logic into REPLServer.prototype._handleError() - Wrap eval execution in replContext.run() for async context tracking - Update newListener protection to check AsyncLocalStorage context - Throw ERR_INVALID_ARG_VALUE if options.domain is passed PR-URL: nodejs#61227

Add auxiliary callback mechanism to setUncaughtExceptionCaptureCallback to allow REPL and domain module to coexist. The REPL uses the new addUncaughtExceptionCaptureCallback API which doesn't conflict with domain's use of the primary callback. - Add addUncaughtExceptionCaptureCallback for non-exclusive callbacks - Update REPL to check for active domain before handling errors - Remove mutual exclusivity checks from domain module - Restore test-repl-domain.js test - Update domain coexistence tests

- Mark addUncaughtExceptionCaptureCallback as experimental - Add changes entry to setUncaughtExceptionCaptureCallback docs - Use validateFunction instead of manual type check

mcollina · 2026-03-05T06:18:55Z

Rebased on top of main and adapted the conflict resolution to use the new ref-counted addProcessNewListener/removeProcessNewListener pattern from #61895, while keeping the AsyncLocalStorage-based check from this PR.

@RafaelGSS @anonrig @marco-ippolito could you re-approve? The only change from the previous version is adapting the processNewListener function to use the upstream's ref-counting pattern instead of the inline addedNewListener boolean.

nodejs-github-bot · 2026-03-05T07:22:40Z

CI: https://ci.nodejs.org/job/node-test-pull-request/71574/

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Dec 30, 2025

avivkeller added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 1, 2026

anonrig approved these changes Jan 6, 2026

View reviewed changes

mcollina force-pushed the repl/remove-domain-dependency branch from 6ef82e6 to e86555a Compare January 10, 2026 10:35

mcollina marked this pull request as ready for review January 10, 2026 10:35

anonrig approved these changes Jan 11, 2026

View reviewed changes

mcollina force-pushed the repl/remove-domain-dependency branch from e86555a to 855468d Compare January 11, 2026 12:46

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 12, 2026

github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jan 12, 2026

marco-ippolito approved these changes Jan 12, 2026

View reviewed changes

marco-ippolito added the needs-citgm PRs that need a CITGM CI run. label Jan 14, 2026

mcollina force-pushed the repl/remove-domain-dependency branch 2 times, most recently from 90dda43 to 045d98f Compare February 7, 2026 07:57

RafaelGSS reviewed Feb 7, 2026

View reviewed changes

mcollina force-pushed the repl/remove-domain-dependency branch from 6f50f41 to 6125d23 Compare February 8, 2026 11:47

RafaelGSS approved these changes Feb 10, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 10, 2026

mcollina added 4 commits March 4, 2026 19:54

doc: add process.addUncaughtExceptionCaptureCallback

5e0f5a3

fixup! repl: remove dependency on domain module

f80a221

- Mark addUncaughtExceptionCaptureCallback as experimental - Add changes entry to setUncaughtExceptionCaptureCallback docs - Use validateFunction instead of manual type check

mcollina force-pushed the repl/remove-domain-dependency branch from 6125d23 to f80a221 Compare March 4, 2026 21:44

marco-ippolito approved these changes Mar 5, 2026

View reviewed changes

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 5, 2026


		This feature is not available in [`Worker`][] threads.

		## `process.addUncaughtExceptionCaptureCallback(fn)`

	throw new ERR_INVALID_ARG_TYPE('fn', 'Function', fn);
	validateFunction(fn, 'fn');

Uh oh!

Conversation

mcollina commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

codecov bot commented Jan 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mcollina commented Jan 10, 2026

Uh oh!

aduh95 commented Jan 10, 2026

Uh oh!

mcollina commented Jan 11, 2026

Uh oh!

github-actions bot commented Jan 12, 2026

Uh oh!

marco-ippolito left a comment

Choose a reason for hiding this comment

Uh oh!

mcollina commented Jan 13, 2026

Uh oh!

RafaelGSS Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

RafaelGSS Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

RafaelGSS Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

RafaelGSS Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

mcollina commented Feb 9, 2026

Uh oh!

nodejs-github-bot commented Feb 10, 2026

Uh oh!

nodejs-github-bot commented Feb 13, 2026

Uh oh!

nodejs-github-bot commented Feb 14, 2026

Uh oh!

avivkeller commented Feb 26, 2026

Uh oh!

mcollina commented Mar 5, 2026

Uh oh!

nodejs-github-bot commented Mar 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

mcollina commented Dec 30, 2025 •

edited

Loading

codecov bot commented Jan 10, 2026 •

edited

Loading