win: improve Add-Type with -IgnoreWarnings#3280
Open
StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
Open
win: improve Add-Type with -IgnoreWarnings#3280StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
StefanStojanovic wants to merge 1 commit intonodejs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds the -IgnoreWarnings parameter to the PowerShell Add-Type command used for Visual Studio detection, following advice from issue #3276 where a user reported node-gyp being unable to find their VS Build Tools installation on Windows 11.
Changes:
- Added
-IgnoreWarningsflag to the PowerShellAdd-Typecommand in thefindNewVSmethod to suppress compiler warnings when loading the C# Visual Studio detection code.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes advice from the referenced issue and makes the logic for finding Visual Studio more robust.
Refs: #3276