fix: fix no commands in compile_commands.json file when using objc files#3187
Open
qwertyyb wants to merge 1 commit intonodejs:mainfrom
Open
fix: fix no commands in compile_commands.json file when using objc files#3187qwertyyb wants to merge 1 commit intonodejs:mainfrom
qwertyyb wants to merge 1 commit intonodejs:mainfrom
Conversation
cclauss
reviewed
Aug 13, 2025
| for source in sources: | ||
| file = resolve(source) | ||
| isc = source.endswith(".c") | ||
| isc = source.endswith(".c") or source.endswith(".m") |
Contributor
There was a problem hiding this comment.
Suggested change
| isc = source.endswith(".c") or source.endswith(".m") | |
| isc = source.endswith((".c", ".m")) |
qwertyyb
force-pushed
the
fix/objc_no_commands_json
branch
from
6493fe7 to
f538c16
Compare
Member
|
Would you mind submitting changes in subdir |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm run lint && npm testpassesDescription of change
fix no commands in compile_commands.json file when using objc files(.m or .mm source files)