Fix nan_weak.h for V8 >= 14.2.194 (missing EmbedderDataTypeTag)#1013
Merged
kkoopa merged 1 commit intonodejs:mainfrom Mar 18, 2026
Merged
Fix nan_weak.h for V8 >= 14.2.194 (missing EmbedderDataTypeTag)#1013kkoopa merged 1 commit intonodejs:mainfrom
kkoopa merged 1 commit intonodejs:mainfrom
Conversation
Commit fcc7b7d added V8 >= 14.2.194 compatibility guards to nan.h for GetAlignedPointerFromInternalField and SetAlignedPointerInInternalField which now require an additional v8::kEmbedderDataTypeTagDefault tag parameter. However, the same unguarded calls in nan_weak.h were missed, causing build failures with Electron 41+ / V8 >= 14.2.194. Apply the exact same preprocessor guard pattern to all occurrences in nan_weak.h.
Collaborator
|
Thank you, I shall get this out right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nan.hforGetAlignedPointerFromInternalFieldandSetAlignedPointerInInternalField(which now require an additionalv8::kEmbedderDataTypeTagDefaulttag parameter), but missed the same unguarded calls innan_weak.hnan.hto the two call sites innan_weak.h(inside theV8 >= 4.3block, which is the only block compiled with V8 14.2+)Test plan
# elsebranches preserve the original calls)