update.sh: remove unnecessary rm operation

[sxa]

Description

This change was added in #757 but I can't see any reason why this piece of code would be executed. The sed command used includes -i which isn't a POSIX standard operation and this code appears to be removing a temporary file that is never actually created because of the use of -i.

Would be good if someone on a mac could verify this since that seems to be the platform that resulted in the -e parameter being added.

Motivation and Context

Testing Details

I've ran update.sh and no -tmp-e files were left behind

Example Output(if appropriate)

Types of changes

• Documentation
• Version change (Update, remove or add more Node.js versions)
• Variant change (Update, remove or add more variants, or versions of variants)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Other (none of the above) - obsolete code

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING.md document.
• All new and existing tests passed.

[sxa]

I can't explicitly add reviewers so tagging @PeterDaveHello who did the referenced PR that introduced these lines.

[nschonni]

@sxa I accepted your request to join the group, since I know you've been active on various other Node Build areas in the past.

[MikeMcC399]

Do we have anybody active with macOS who could cross-check? The code was added in 2018 apparently.

The PR now has conflicts to be resolved.

[nschonni]

Approving, since this likely will only impact the maintainers if it was fixing something. If it is helping on some OS, we'll start to see noise from external people.
Maybe the "fix" for that is just .gitignore anyway

[aduh95]

Would be good if someone on a mac could verify this since that seems to be the platform that resulted in the -e parameter being added.

FWIW I cannot execute ./update.sh on my Mac, because of the use of non-portable flags such as -i you mentioned:

$ ./update.sh                                                                                                        
Updating version 22...
Updating version 24...
Updating version 26...
sed: 2: ":a;N;$!ba;s/\n/\\\\n/g
": unused label 'a;N;$!ba;s/\n/\\\\n/g'
sed: -e: No such file or directory
…

It does however leave some Dockerfile-tmp-e files which would be removed without this PR.

FWIW I usually run it with nix-shell -p gawk -p gnused --run ./update.sh (i.e. using the GNU utilities), and avoid the incompatibility issues altogether.