Skip to content

Comments

meta: specify architecture#614

Closed
ovflowd wants to merge 1 commit intomainfrom
meta/specify-architecture
Closed

meta: specify architecture#614
ovflowd wants to merge 1 commit intomainfrom
meta/specify-architecture

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 18, 2026

This PR tightens the architecture for dependencies to be wasm whenever possible.

npm install --cpu wasm32 --os wasip1-threads

Copilot AI review requested due to automatic review settings February 18, 2026 16:33
@ovflowd ovflowd requested a review from a team as a code owner February 18, 2026 16:33
@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Feb 18, 2026 4:33pm

Request Review

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.62%. Comparing base (32a824c) to head (795b1f6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #614   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files         128      128           
  Lines       12461    12461           
  Branches      902      902           
=======================================
  Hits         9798     9798           
  Misses       2658     2658           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

orama-db Generator

File Base Head Diff
orama-db.json 8.03 MB 8.03 MB -1.78 KB (-0.02%)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • npm-shrinkwrap.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 966 to 8968
@@ -1032,7 +1031,6 @@
"resolved": "https://registry.npmjs.org/@orama/cuid2/-/cuid2-2.2.3.tgz",
"integrity": "sha512-Lcak3chblMejdlSHgYU2lS2cdOhDpU6vkfIJH4m+YKvqQyLqs1bB8+w6NT1MG5bO12NUK2GFc34Mn2xshMIQ1g==",
"license": "MIT",
"peer": true,
"dependencies": {
"@noble/hashes": "^1.1.5"
}
@@ -1050,8 +1048,7 @@
"version": "0.0.5",
"resolved": "https://registry.npmjs.org/@orama/oramacore-events-parser/-/oramacore-events-parser-0.0.5.tgz",
"integrity": "sha512-yAuSwog+HQBAXgZ60TNKEwu04y81/09mpbYBCmz1RCxnr4ObNY2JnPZI7HmALbjAhLJ8t5p+wc2JHRK93ubO4w==",
"license": "AGPL-3.0",
"peer": true
"license": "AGPL-3.0"
},
"node_modules/@orama/stopwords": {
"version": "3.1.16",
@@ -3257,6 +3254,7 @@
"integrity": "sha512-9Cnda8GS57AQakvRyG0PTejJNlA2xhvyNtEVIMlDWOOeEyBkYWhGPnfrIAnqxLMTSTo6q8g12XVjjev5l1NvMA==",
"dev": true,
"license": "MIT",
"peer": true,
"dependencies": {
"@eslint-community/eslint-utils": "^4.9.1",
"@typescript-eslint/scope-manager": "8.54.0",
@@ -3646,6 +3644,7 @@
"resolved": "https://registry.npmjs.org/acorn/-/acorn-8.15.0.tgz",
"integrity": "sha512-NZyJarBfL7nWwIq+FDL6Zp/yHEhePMNnnJ0y3qfieCrmNvYct8uvtiV41UvlSe6apAfk0fY1FbWx+NwfmpvtTg==",
"license": "MIT",
"peer": true,
"bin": {
"acorn": "bin/acorn"
},
@@ -4187,8 +4186,7 @@
"version": "3.1.3",
"resolved": "https://registry.npmjs.org/csstype/-/csstype-3.1.3.tgz",
"integrity": "sha512-M1uQkMl8rQK/szD0LNhtqxIPLpimGm8sOBwU7lLnCpSbTyY3yeU1Vc7l4KT5zT4s/yOxHH5O7tIuuLOCnLADRw==",
"license": "MIT",
"peer": true
"license": "MIT"
},
"node_modules/debug": {
"version": "4.4.3",
@@ -4391,6 +4389,7 @@
"integrity": "sha512-LEyamqS7W5HB3ujJyvi0HQK/dtVINZvd5mAAp9eT5S/ujByGjiZLCzPcHVzuXbpJDJF/cxwHlfceVUDZ2lnSTw==",
"dev": true,
"license": "MIT",
"peer": true,
"dependencies": {
"@eslint-community/eslint-utils": "^4.8.0",
"@eslint-community/regexpp": "^4.12.1",
@@ -7083,6 +7082,7 @@
}
],
"license": "MIT",
"peer": true,
"dependencies": {
"nanoid": "^3.3.11",
"picocolors": "^1.1.1",
@@ -7132,6 +7132,7 @@
"resolved": "https://registry.npmjs.org/preact/-/preact-11.0.0-beta.0.tgz",
"integrity": "sha512-IcODoASASYwJ9kxz7+MJeiJhvLriwSb4y4mHIyxdgaRZp6kPUud7xytrk/6GZw8U3y6EFJaRb5wi9SrEK+8+lg==",
"license": "MIT",
"peer": true,
"funding": {
"type": "opencollective",
"url": "https://opencollective.com/preact"
@@ -7634,8 +7635,7 @@
"version": "0.26.0",
"resolved": "https://registry.npmjs.org/scheduler/-/scheduler-0.26.0.tgz",
"integrity": "sha512-NlHwttCI/l5gCPR3D1nNXtWABUmBwvZpEQiD4IXSbIDq8BzLIK/7Ir5gTFSGZDUu37K5cMNp0hFtzO38sC7gWA==",
"license": "MIT",
"peer": true
"license": "MIT"
},
"node_modules/semver": {
"version": "7.7.3",
@@ -8180,6 +8180,7 @@
"resolved": "https://registry.npmjs.org/picomatch/-/picomatch-4.0.3.tgz",
"integrity": "sha512-5gTmgEY/sqK6gFXLIsQNH19lWb4ebPDLA4SdLP7dsWkIXHWlG66oPuVvXSGFPppYZz8ZDZq0dYYrbHfBCVUb1Q==",
"license": "MIT",
"peer": true,
"engines": {
"node": ">=12"
},
@@ -8534,6 +8535,7 @@
"integrity": "sha512-VUyWiTNQD7itdiMuJy+EuLEErLj3uwX/EpHQF8EOf33Dq3Ju6VW1GXm+swk6+1h7a49uv9fKZ+dft9jU7esdLA==",
"dev": true,
"hasInstallScript": true,
"peer": true,
"dependencies": {
"napi-postinstall": "^0.2.4"
},
@@ -8964,7 +8966,6 @@
"resolved": "https://registry.npmjs.org/zod-to-json-schema/-/zod-to-json-schema-3.24.5.tgz",
"integrity": "sha512-/AuWwMP+YqiPbsJx5D6TfgRTc4kTLjsh5SOcd4bLsfUg2RcEXrFMJl1DGgdHy2aCfsIA/cr/1JM0xcB2GZji8g==",
"license": "ISC",
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states "This PR tightens the architecture for dependencies to be wasm whenever possible," but the actual changes in this file are about modifying peer dependency flags in the npm lockfile, which has no relation to WebAssembly (wasm) architecture.

The changes involve:

  • Removing "peer": true from packages like @noble/hashes, @orama packages, csstype, scheduler, and zod-to-json-schema
  • Adding "peer": true to packages like @typescript-eslint/parser, acorn, eslint-plugin-jsdoc, postcss, preact, and vite

These modifications affect npm's dependency resolution strategy but are unrelated to wasm. The project already uses wasm packages (lightningcss-wasm, @minify-html/wasm) which are not being changed. Either the PR description is incorrect, or these changes were committed to the wrong PR.

Copilot uses AI. Check for mistakes.
"resolved": "https://registry.npmjs.org/acorn/-/acorn-8.15.0.tgz",
"integrity": "sha512-NZyJarBfL7nWwIq+FDL6Zp/yHEhePMNnnJ0y3qfieCrmNvYct8uvtiV41UvlSe6apAfk0fY1FbWx+NwfmpvtTg==",
"license": "MIT",
"peer": true,
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The acorn package is listed as a direct dependency in package.json (line 52) but is being marked with "peer": true in the lockfile. In npm lockfile v3 format, the "peer": true flag indicates a package is installed only to satisfy peer dependency requirements, not as a direct dependency. This conflict could cause acorn to not be installed properly, leading to runtime errors when the code tries to import it. The same issue exists for other packages marked as peer despite being direct dependencies.

Suggested change
"peer": true,

Copilot uses AI. Check for mistakes.
"resolved": "https://registry.npmjs.org/preact/-/preact-11.0.0-beta.0.tgz",
"integrity": "sha512-IcODoASASYwJ9kxz7+MJeiJhvLriwSb4y4mHIyxdgaRZp6kPUud7xytrk/6GZw8U3y6EFJaRb5wi9SrEK+8+lg==",
"license": "MIT",
"peer": true,
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The preact package is listed as a direct dependency in package.json (line 64) but is being marked with "peer": true in the lockfile. In npm lockfile v3 format, the "peer": true flag indicates a package is installed only to satisfy peer dependency requirements, not as a direct dependency. This conflict could cause preact to not be installed properly, leading to runtime errors when the code tries to import it. Preact is used directly in the codebase for rendering components, so it must be installed as a direct dependency.

Suggested change
"peer": true,

Copilot uses AI. Check for mistakes.
@avivkeller avivkeller self-assigned this Feb 18, 2026
@avivkeller avivkeller closed this Feb 18, 2026
@avivkeller
Copy link
Member

Looking over the diff, the lock file didn’t actually add a dependency :-/. I’ll look into the other dynamic importing approach I mentionex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants