Skip to content

Comments

fix: use wasm#611

Merged
avivkeller merged 1 commit intomainfrom
fix/fix-dependency-pinning-lightningcss
Feb 18, 2026
Merged

fix: use wasm#611
avivkeller merged 1 commit intomainfrom
fix/fix-dependency-pinning-lightningcss

Conversation

@ovflowd
Copy link
Member

@ovflowd ovflowd commented Feb 18, 2026

This PR solves downstream failures due to lack of Rust, by using LightningCSS WASM version. It also fixes the dependency pinning using safer versions.

@ovflowd ovflowd requested a review from a team as a code owner February 18, 2026 14:13
Copilot AI review requested due to automatic review settings February 18, 2026 14:13
@vercel
Copy link

vercel bot commented Feb 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
api-docs-tooling Ready Ready Preview Feb 18, 2026 2:45pm

Request Review

@codecov
Copy link

codecov bot commented Feb 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.62%. Comparing base (470ac2c) to head (4c207cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files         128      128           
  Lines       12461    12461           
  Branches      902      902           
=======================================
  Hits         9798     9798           
  Misses       2658     2658           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented Feb 18, 2026

It also fixes the dependency pinning using safer versions.

How is it safer given we have a lock file anyway?

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

orama-db Generator

File Base Head Diff
orama-db.json 8.03 MB 8.03 MB -1.00 B (-0.00%)

web Generator

File Base Head Diff
styles.css 128.14 KB 128.21 KB +67.00 B (+0.05%)

@ovflowd
Copy link
Member Author

ovflowd commented Feb 18, 2026

It also fixes the dependency pinning using safer versions.

How is it safer given we have a lock file anyway?

It just follows our best practices for dependency pinning. I agree that technically speaking with a shrinkwrap there's no real difference. This is our team's guide: https://github.com/nodejs/nodejs.org/blob/main/docs/dependency-pinning.md

@ovflowd
Copy link
Member Author

ovflowd commented Feb 18, 2026

cc @nodejs/web-infra / @avivkeller I'm requesting fast-tracking to unblock downstream PR. 👍 / 👎

@MattIPv4
Copy link
Member

It also fixes the dependency pinning using safer versions.

How is it safer given we have a lock file anyway?

It just follows our best practices for dependency pinning. I agree that technically speaking with a shrinkwrap there's no real difference. This is our team's guide: https://github.com/nodejs/nodejs.org/blob/main/docs/dependency-pinning.md

Looking at both https://github.com/nodejs/nodejs.org/blob/main/package.json and https://github.com/nodejs/nodejs.org/blob/main/apps/site/package.json it doesn't seem like we blanket pin everything to an exact version, so why are we doing that here?

@ovflowd
Copy link
Member Author

ovflowd commented Feb 18, 2026

It also fixes the dependency pinning using safer versions.

How is it safer given we have a lock file anyway?

It just follows our best practices for dependency pinning. I agree that technically speaking with a shrinkwrap there's no real difference. This is our team's guide: https://github.com/nodejs/nodejs.org/blob/main/docs/dependency-pinning.md

Looking at both https://github.com/nodejs/nodejs.org/blob/main/package.json and https://github.com/nodejs/nodejs.org/blob/main/apps/site/package.json it doesn't seem like we blanket pin everything to an exact version, so why are we doing that here?

Hmm, yes, agree, the diff shouldnt have pinned everything, only applicable things, commit went awry

@avivkeller
Copy link
Member

avivkeller commented Feb 18, 2026

Feel free to fast track once you reverted the dependency changes

@avivkeller
Copy link
Member

Regardless of there relevance to the project, they are irrelevant to this PR

@ovflowd
Copy link
Member Author

ovflowd commented Feb 18, 2026

Regardless of there relevance to the project, they are irrelevant to this PR

No, they are relevant, or at least I deem them relevant. We can disagree on that 🤷

@avivkeller avivkeller force-pushed the fix/fix-dependency-pinning-lightningcss branch from e220943 to 4c207cd Compare February 18, 2026 14:43
@avivkeller avivkeller changed the title fix: dependency pinning, use wasm fix: use wasm Feb 18, 2026
@avivkeller avivkeller requested a review from MattIPv4 February 18, 2026 14:43
@avivkeller avivkeller added the fast track This PR can land before the typical review time, with a :+1: from collaborators label Feb 18, 2026
@avivkeller avivkeller merged commit 32a824c into main Feb 18, 2026
20 checks passed
@avivkeller avivkeller deleted the fix/fix-dependency-pinning-lightningcss branch February 18, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast track This PR can land before the typical review time, with a :+1: from collaborators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants