Allow helper to test the URL defined by http in node#31
Open
HirokiUchikawa wants to merge 1 commit intonode-red:masterfrom
Open
Allow helper to test the URL defined by http in node#31HirokiUchikawa wants to merge 1 commit intonode-red:masterfrom
HirokiUchikawa wants to merge 1 commit intonode-red:masterfrom
Conversation
|
@HirokiUchikawa many thanks!! |
|
Hi, I tried out this PR with this spec. (merged to 0.2.3 release) Its works for me (I have custom HttpIn node ) 3 passing (235ms) |
|
We really need this fix to be merged to test some endpoints in our nodes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently
helper.request()supports testing editor/admin URL, but it cannot request the URL which defined byhttp in node.This is because
helper.request()does not handleruntime.httpNodewhich routes a request to the path defined by the node.I fixed it in order to support
runtime.httpNode.This PR will fix #29.
Checklist
gruntto verify the unit tests pass