Skip to content

Update nanort version and include path.#208

Closed
jdumas wants to merge 1 commit intonmwsharp:masterfrom
jdumas:jdumas/nanort
Closed

Update nanort version and include path.#208
jdumas wants to merge 1 commit intonmwsharp:masterfrom
jdumas:jdumas/nanort

Conversation

@jdumas
Copy link
Copy Markdown
Contributor

@jdumas jdumas commented Jan 23, 2025

This PR updates the include path of nanort in geometry central to facilitate using the upstream nanort repository. I.e. users should #include <nanort.h> and not <nanort/nanort.h>.

Additionally, since nanort in geometry central is 8 years old, I though we could update it as well, as geometry central code isn't compatible with the latest nanort API.

@nmwsharp
Copy link
Copy Markdown
Owner

Thank you for submitting this. I believe this is fully handled by the changes in #242 incorporating these. If not please re-open!

There were several overlapping issues/PRs about the way nanoflann/nanort are handled.

I tried to unify & fix so now:

  • Both nanort and nanoflann live on their standard paths
  • Remove old backwards compatible code preserving old paths (this is a small breaking change, better than the confusion of multiple paths)
  • Make nanort an private dependency similar to nanoflann make install/link in large codebases easier
  • Create a small tracer class exposing nanort

@nmwsharp nmwsharp closed this Apr 27, 2026
@jdumas
Copy link
Copy Markdown
Contributor Author

jdumas commented Apr 28, 2026

Thanks. Out of curiosity, have you thought about using FetchContent/CPM to manage those dependencies? Then you could setup something like Dependabot/Renovate to keep them updated without breaking a sweat. It should be less work in the long run, and I'm happy to help if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants