Update nanort version and include path.#208
Closed
jdumas wants to merge 1 commit intonmwsharp:masterfrom
Closed
Conversation
Closed
Owner
|
Thank you for submitting this. I believe this is fully handled by the changes in #242 incorporating these. If not please re-open! There were several overlapping issues/PRs about the way nanoflann/nanort are handled. I tried to unify & fix so now:
|
Contributor
Author
|
Thanks. Out of curiosity, have you thought about using FetchContent/CPM to manage those dependencies? Then you could setup something like Dependabot/Renovate to keep them updated without breaking a sweat. It should be less work in the long run, and I'm happy to help if you want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the include path of nanort in geometry central to facilitate using the upstream nanort repository. I.e. users should
#include <nanort.h>and not<nanort/nanort.h>.Additionally, since nanort in geometry central is 8 years old, I though we could update it as well, as geometry central code isn't compatible with the latest nanort API.