Update target_include_directories to make geometry-central installable#190
Open
jdumas wants to merge 1 commit intonmwsharp:masterfrom
Open
Update target_include_directories to make geometry-central installable#190jdumas wants to merge 1 commit intonmwsharp:masterfrom
jdumas wants to merge 1 commit intonmwsharp:masterfrom
Conversation
Owner
|
Hi! I just merged another PR addressing some of the same issues. #238 From my understanding this should be sorted out now. Please let me know if not! Otherwise I will close this PR next time I come back to it. |
Contributor
Author
|
Ugh. I don't like the changes in #238. Hardcoding the include directories for happly/nanort/etc. to relative paths will prevent any downstream users from using geometry-central via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this SO thread for a description of the issue.