Fix double encode of the payload on failed log #27
Open
lsimeonov wants to merge 6 commits intonicholasnet:masterfrom
Open
Fix double encode of the payload on failed log #27lsimeonov wants to merge 6 commits intonicholasnet:masterfrom
lsimeonov wants to merge 6 commits intonicholasnet:masterfrom
Conversation
Made paused property a public isPaused method.
Merge commit (nicholasnet#24)
…uble encode the payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When raw JSON payload gets passed to
setPayloadit gets inserted as an escaped string in the database. Thus leading to wrong retrieved payload data - string instead of arraysetPayloadshould expect array and doctrine is handling the conversion to the database field.Note: mysql 5.7 here with json field for the doctrine payload column.