nmc/4516-files-sharing-password-disabled-after-editing-advanced-permission-without-changes-to-password#70
Open
suet-kei-chan wants to merge 1 commit into
Conversation
…etails - Replace 'Replace current password' label with 'Password set' when a password is already set - Hide password input field when password is already set - Add 'Change password' button with pencil icon to reveal the input field on demand - Add translations for new strings across all supported locales
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
The password section in the Sharing Details / Advanced Settings panel has been improved to better reflect the current password state.
Before:
When a password was already set, the checkbox label showed "Replace current password" (taken from files_sharing domain)
The password input field was always visible when the checkbox was checked
After:
When a password is already set, the checkbox label now shows "Password set"
The password input field is hidden when a password is already set
A "Change password" button with a pencil icon appears next to the checkbox — clicking it reveals the input field so the user can enter a new password
How to Test
Open the Files app and right-click any file/folder → Sharing options
Click the share link row to open Advanced settings
Case A — No existing password:
Check the "Set password" checkbox → input field should appear
Case B — Existing password (set one first and save):
Reopen Advanced settings → label should say "Password set", input field should be hidden
Click "Change password ✏️" → input field should appear so you can enter a new one
Verify translations by switching the Nextcloud language to German (de / de_DE) and repeating the above — labels should show "Passwort gesetzt" and "Passwort ändern"