Open
Conversation
AndyScherzinger
force-pushed
the
feat/noid/profileComposable
branch
from
a1a692f to
7c08cfb
Compare
AndyScherzinger
added
3. to review
AndyScherzinger
force-pushed
the
feat/noid/profileComposable
branch
3 times, most recently
from
fe6e794 to
6dfb58e
Compare
AndyScherzinger
added
2. developing
AI-assistant: Claude Code v2.1.72 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…y away from adapter to mutableList AI-assistant: Claude Code v2.1.74 (Claude Sonnet 4.6) Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
feat/noid/profileComposable
branch
from
18e7c37 to
a88468f
Compare
Contributor
Contributor
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5943.apk |
AndyScherzinger
added
design
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MutableListinsteadNote: Ultimately but not done by this PR we should move to MVVM - When having/implementing a
ProfileViewModel, the item list andupdateScopebelong there as aStateFlow<List<UserInfoDetailsItem>>.ScopeDialog'sonScopeSelectedwould callviewModel.updateScope(position, scope)and the UI observes the flow. This would be even cleaner but is a larger refactor, making the review more complex. So better do it step by step.🖼️ Screenshots
🚧 TODO
🏁 Checklist
/backport to stable-xx.x