fix(appstore): show reason why limit app to groups is not possible#60361
Open
susnux wants to merge 1 commit into
Open
fix(appstore): show reason why limit app to groups is not possible#60361susnux wants to merge 1 commit into
susnux wants to merge 1 commit into
Conversation
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
requested review from
nfebe,
skjnldsv and
sorbaugh
and removed request for
a team
susnux
requested review from
pringelmann and
szaimen
and removed request for
sorbaugh
skjnldsv
approved these changes
May 13, 2026
Member
skjnldsv
left a comment
skjnldsv
left a comment
There was a problem hiding this comment.
Lack of better wording on my side, so you get my approval 😊
| </NcNoteCard> | ||
|
|
||
| <NcNoteCard v-if="cannotLimitToGroups" type="info"> | ||
| {{ t('appstore', 'This app cannot be limited to groups because this app provides functionallity that is executed before group membership is determined.') }} |
Member
There was a problem hiding this comment.
That seems a bit overcomplicated 🤭
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)AI (if applicable)