Conditional Logic by mickenordin · Pull Request #3123 · nextcloud/forms

mickenordin · 2026-01-18T18:19:11Z

This is an implementation of Conditional Logic. It is not well tested, and I would appreciate review and testing by others to see if it works as intended. I have created a few forms and clicked around to the best of my abilities, but I have implemented the fix for the benefit of others that need it and have no real use case myself to test with.

Fixes: #358

codecov · 2026-01-18T18:59:15Z

Codecov Report

❌ Patch coverage is 51.41509% with 206 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/Controller/ApiController.php	55.21%	73 Missing ⚠️
lib/Service/SubmissionService.php	49.25%	68 Missing ⚠️
lib/Db/QuestionMapper.php	0.00%	39 Missing ⚠️
lib/Migration/Version050300Date20260118000000.php	0.00%	19 Missing ⚠️
lib/Service/FormsService.php	89.23%	7 Missing ⚠️

📢 Thoughts on this report? Let us know!

mickenordin · 2026-01-18T20:39:11Z

Codecov Report

❌ Patch coverage is 56.88073% with 141 lines in your changes missing coverage. Please review.
Files with missing lines Patch % Lines
lib/Service/SubmissionService.php 48.87% 68 Missing ⚠️
lib/Db/QuestionMapper.php 0.00% 39 Missing ⚠️
lib/Migration/Version050300Date20260118000000.php 0.00% 19 Missing ⚠️
lib/Controller/ApiController.php 86.04% 12 Missing ⚠️
lib/Service/FormsService.php 93.47% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Updated with more tests so threshold is well exceeded

github-actions · 2026-02-02T02:18:47Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

timedin-de · 2026-04-27T23:28:17Z

Thank you! Will test further. It seems a bit sluggish sometimes it throws an
{"ocs":{"meta":{"status":"failure","statuscode":400,"message":"Invalid extraSettings, will not update."},"data":[]}} but seems to work otherwise.

This is the missing feature i need to convince my non-profit to stop using google forms 🙏

timedin-de · 2026-05-10T15:04:00Z

mickenordin · 2026-05-10T15:11:30Z

Yes

Hi @mickenordin , as this was stale for 3 Months i started fixing some bugs by myself. I cant push on this branch, should i just post my .patch diffs here?

Problems noticed/fixed:

* [x]  Error Messages while editing

* [x]   design fixes (hiding header and the broken trigger question header)

* [x]  cloning subquestions

* [x]  hiding unused "Clone" on triggerquestion

* [x]  fixing options (three dot menu) on questions

* [x]  fix options and extraSettings on subquestions not safed

* [x]  result view (currently only Detail View)

* [ ]  result view Overview

* [ ]  export of subquestions

* [ ]  reordering/moving/dragging of subquestions

* [ ]  subquestion fileupload not shown in results

* [ ]  clear not working

* [ ]  complex conditions (like number between....) not working

Further ideas for this (should be new PR):

* [ ]  nested conditionals

Yes, please do. I don't know of a better way since I don't have access to any access settings in the Nextcloud org, even though I was given the ability to branch in their repos myself.

I'll make sure to credit you on the diffs of course.

timedin-de · 2026-05-30T01:12:13Z

Hey @mickenordin
as I rebased the branch (including changing your commit, to support the new question types etc.) i guess it makes more sense to reset to my branch, if you want.

git remote add timedin git@github.com:timedin-de/forms.git
git fetch timedin
git reset timedin/kano-conditional --hard
git push --force-with-lease --force-if-includes

mickenordin · 2026-05-30T09:04:07Z

Hey @mickenordin as I rebased the branch (including changing your commit, to support the new question types etc.) i guess it makes more sense to reset to my branch, if you want.
git remote add timedin git@github.com:timedin-de/forms.git
git fetch timedin
git reset timedin/kano-conditional --hard
git push --force-with-lease --force-if-includes

I did, please make sure to sign-off your commits, and perhaps squash them to fewer logical units. You can take a look at the failing tests and see how to fix them.

timedin-de · 2026-06-02T22:09:22Z

hey @mickenordin thanks for the fast update. I signed off the commits, removed the test (thats no longer relevant) and squashed some commits (tell me if you think i should squash them more). Also i rebased my branch again including the new Transition and "InsertHere" features

This is an implementation of Conditional Logic. It is not well tested, and I would appreciate review and testing by others to see if it works as intended. I have created a few forms and clicked around to the best of my abilities, but I have implemented the fix for the benefit of others that need it and have no real use case myself to test with. Fixes: #358 Signed-off-by: Micke Nordin <kano@sunet.se>

fix: hide trigger type header on read fix: hide broken title on trigger question fix: clear button fix: aria labeled by index fix: conditional-file-upload Signed-off-by: TimedIn <git@timedin.net>

fix: hide clone on trigger question fix: link trigger question delete btn Signed-off-by: TimedIn <git@timedin.net>

Signed-off-by: TimedIn <git@timedin.net>

fix: export of subquestions Signed-off-by: TimedIn <git@timedin.net>

Signed-off-by: TimedIn <git@timedin.net>

fix: reordering and dragging Signed-off-by: TimedIn <git@timedin.net>

Signed-off-by: TimedIn <git@timedin.net>

…n' to conditional Signed-off-by: TimedIn <git@timedin.net>

Signed-off-by: TimedIn <git@timedin.net>

- validate active-branch subquestions with full per-question rules - persist subquestion answers only for the activated branch - use -PHP_FLOAT_MAX as the value_range lower bound - drop unused QuestionMapper::deleteByParentQuestion Signed-off-by: Micke Nordin <kano@sunet.se>

mickenordin · 2026-06-03T12:28:20Z

hey @mickenordin thanks for the fast update. I signed off the commits, removed the test (thats no longer relevant) and squashed some commits (tell me if you think i should squash them more). Also i rebased my branch again including the new Transition and "InsertHere" features

I incorporated that, and added a commit with some fixes I thought valuable, can you test with the lastest state of this branch?

timedin-de · 2026-06-04T07:39:50Z

@mickenordin some test fail now and my fix for Detail Answers seems to no longer work (i dont see subquestions there anymore)

mickenordin force-pushed the kano-conditional branch 2 times, most recently from c7ff7a9 to 7887848 Compare January 18, 2026 18:57

mickenordin force-pushed the kano-conditional branch 7 times, most recently from 2d5f073 to 50a1acd Compare January 18, 2026 20:17

mickenordin force-pushed the kano-conditional branch from 50a1acd to 2250d5f Compare January 19, 2026 11:21

mickenordin changed the title ~~WIP: Conditional Logic~~ Conditional Logic Jan 19, 2026

mickenordin marked this pull request as ready for review January 19, 2026 11:21

mickenordin force-pushed the kano-conditional branch from 2250d5f to 3aea864 Compare January 20, 2026 09:58

github-actions Bot added the feedback-requested label Feb 2, 2026

mickenordin force-pushed the kano-conditional branch 3 times, most recently from 5c7d036 to d02bdbc Compare February 15, 2026 12:05

mickenordin requested review from Chartman123 and Koc February 15, 2026 12:10

mickenordin force-pushed the kano-conditional branch from d02bdbc to 78643a6 Compare February 23, 2026 11:06

Chartman123 added this to the 5.4 milestone May 13, 2026

mickenordin force-pushed the kano-conditional branch from 78643a6 to 532bee6 Compare May 30, 2026 08:59

mickenordin force-pushed the kano-conditional branch 2 times, most recently from 3c4c8b3 to 18808aa Compare May 31, 2026 19:13

mickenordin force-pushed the kano-conditional branch from 18808aa to dac037e Compare June 3, 2026 12:09

mickenordin and others added 12 commits June 3, 2026 14:09

fix: allow empty branches, fixes

24fcc48

fix: hide trigger type header on read fix: hide broken title on trigger question fix: clear button fix: aria labeled by index fix: conditional-file-upload Signed-off-by: TimedIn <git@timedin.net>

fix: cloning subquestions

c5e3d3c

fix: hide clone on trigger question fix: link trigger question delete btn Signed-off-by: TimedIn <git@timedin.net>

fix: trigger question options

d9a7149

Signed-off-by: TimedIn <git@timedin.net>

fix: show conditional answers in detail view

9c984be

fix: export of subquestions Signed-off-by: TimedIn <git@timedin.net>

fix: save options and extraSettings for subquestions

4ce5313

Signed-off-by: TimedIn <git@timedin.net>

fix: move up/down for subquestions

0e0e7aa

fix: reordering and dragging Signed-off-by: TimedIn <git@timedin.net>

feat: add ranking-question to conditional

b63349a

Signed-off-by: TimedIn <git@timedin.net>

fix: multiple active branches

b7603cd

Signed-off-by: TimedIn <git@timedin.net>

fix: selectors for linear scale

bdc1666

Signed-off-by: TimedIn <git@timedin.net>

fix: extract question list to seperate component, add 'insert questio…

19877cc

…n' to conditional Signed-off-by: TimedIn <git@timedin.net>

feat: adding transition to conditional branches

77070f3

Signed-off-by: TimedIn <git@timedin.net>

mickenordin force-pushed the kano-conditional branch from dac037e to 77070f3 Compare June 3, 2026 12:09

mickenordin added the 3. to review Waiting for reviews label Jun 3, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conditional Logic#3123

Conditional Logic#3123
mickenordin wants to merge 13 commits into
mainfrom
kano-conditional

mickenordin commented Jan 18, 2026 •

edited

Loading

Uh oh!

codecov Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

mickenordin commented Jan 18, 2026

Codecov Report

Uh oh!

github-actions Bot commented Feb 2, 2026

Uh oh!

timedin-de commented Apr 27, 2026

Uh oh!

timedin-de commented May 10, 2026 •

edited

Loading

Uh oh!

mickenordin commented May 10, 2026 •

edited

Loading

Uh oh!

timedin-de commented May 30, 2026

Uh oh!

mickenordin commented May 30, 2026

Uh oh!

timedin-de commented Jun 2, 2026

Uh oh!

mickenordin commented Jun 3, 2026

Uh oh!

timedin-de commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mickenordin commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mickenordin commented Jan 18, 2026

Codecov Report

Uh oh!

github-actions Bot commented Feb 2, 2026

Uh oh!

timedin-de commented Apr 27, 2026

Uh oh!

timedin-de commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mickenordin commented May 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

timedin-de commented May 30, 2026

Uh oh!

mickenordin commented May 30, 2026

Uh oh!

timedin-de commented Jun 2, 2026

Uh oh!

mickenordin commented Jun 3, 2026

Uh oh!

timedin-de commented Jun 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mickenordin commented Jan 18, 2026 •

edited

Loading

codecov Bot commented Jan 18, 2026 •

edited

Loading

timedin-de commented May 10, 2026 •

edited

Loading

mickenordin commented May 10, 2026 •

edited

Loading