Skip to content

fix(e2ee): version detection#17103

Open
alperozturk96 wants to merge 13 commits into
masterfrom
fix/e2ee-version-detection
Open

fix(e2ee): version detection#17103
alperozturk96 wants to merge 13 commits into
masterfrom
fix/e2ee-version-detection

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

@alperozturk96 alperozturk96 mentioned this pull request May 29, 2026
Merged
@alperozturk96 alperozturk96 marked this pull request as draft May 29, 2026 06:59
@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26623118958/artifacts/7285051492
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/26626813195/artifacts/7286688680
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-version-detection branch from c86d000 to 28f268c Compare June 12, 2026 07:59
alperozturk96
alperozturk96 commented Jun 12, 2026
View reviewed changes
Comment thread app/src/main/java/com/nextcloud/utils/e2ee/E2EVersionHelper.kt
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27402851073/artifacts/7586314471
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27403838656/artifacts/7586785530
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 added this to the Nextcloud App 34.0.1 milestone Jun 12, 2026
@alperozturk96

alperozturk96 commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator Author

/backport to stable-34.0.x

@alperozturk96 alperozturk96 marked this pull request as ready for review June 12, 2026 09:30
@nextcloud nextcloud deleted a comment from github-actions Bot Jun 12, 2026
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27407225960/artifacts/7589399283
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

tobiasKaminsky
tobiasKaminsky reviewed Jun 17, 2026
View reviewed changes
Comment thread app/src/androidTest/java/com/nextcloud/utils/EndToEndEncryptionVersionTests.kt Outdated
tobiasKaminsky
tobiasKaminsky reviewed Jun 17, 2026
View reviewed changes
Comment thread app/src/androidTest/java/com/nextcloud/utils/EndToEndEncryptionVersionTests.kt Outdated
tobiasKaminsky
tobiasKaminsky requested changes Jun 17, 2026
View reviewed changes
Comment thread app/src/androidTest/java/com/nextcloud/utils/EndToEndEncryptionVersionTests.kt Outdated
Comment thread app/src/main/java/com/nextcloud/utils/e2ee/E2EVersionHelper.kt Outdated
Comment thread gradle/libs.versions.toml Outdated
@alperozturk96 alperozturk96 force-pushed the fix/e2ee-version-detection branch from 8eb6352 to 5b79c24 Compare June 17, 2026 10:15
@alperozturk96 alperozturk96 force-pushed the fix/e2ee-version-detection branch from 88116a1 to bfef815 Compare June 17, 2026 10:29
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27682571775/artifacts/7693306944
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 marked this pull request as draft June 17, 2026 11:05
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27684306951/artifacts/7693774636
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 force-pushed the fix/e2ee-version-detection branch from 6a81612 to 89fd242 Compare June 17, 2026 11:26
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27685550182/artifacts/7694074001
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@alperozturk96 alperozturk96 mentioned this pull request Jun 17, 2026
Merged
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27690061857/artifacts/7697065653
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@tobiasKaminsky tobiasKaminsky marked this pull request as ready for review June 18, 2026 06:19
@tobiasKaminsky tobiasKaminsky force-pushed the fix/e2ee-version-detection branch from 1fb5981 to 32a29d8 Compare June 18, 2026 06:26
alperozturk96 and others added 13 commits June 18, 2026 09:42
@alperozturk96 @tobiasKaminsky
fix(e2ee): version detection
6ee1234 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
use capabilities e2e api version instead latest
3f6394e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
do not use hardcoded v1 always rely on capabilities
5e7000c 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
use getMaxCompatibleE2EEVersion
9a7c9ab 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
4875efa 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
b09e347 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
8d41e5a 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
8d3f47b 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
fix lint
65ee349 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
0650f8f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
99cdc1f 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96 @tobiasKaminsky
wip
9f6d015 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@tobiasKaminsky
Use latest lib
8c7cf64 
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@tobiasKaminsky tobiasKaminsky force-pushed the fix/e2ee-version-detection branch from 32a29d8 to 8c7cf64 Compare June 18, 2026 07:43
@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3333
Correctness6767
Dodgy code214214
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3131
Performance4141
Security1616
Total412412

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/27744507986/artifacts/7717274546
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

Assignees

No one assigned

Labels

3. to review backport-request

Projects

None yet

Milestone

Nextcloud App 34.0.1

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96 @tobiasKaminsky