don't set oc upload size before upload#16533
Open
alperozturk96 wants to merge 3 commits intomasterfrom
Open
Conversation
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
changed the title
Collaborator
Author
|
/backport to stable-3.36 |
alperozturk96
commented
Feb 17, 2026
| mCancellationRequested.set(false); | ||
| mUploadStarted.set(true); | ||
|
|
||
| updateSize(0); |
Collaborator
Author
There was a problem hiding this comment.
I think this sets the OCUpload size to 0 but after this line upload not happening and db stuck with this value.
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16533.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since upload functions sets the correct file size, no need to set file size to 0 before the actual upload
Adds logs for failing cases