Added Boolean fied to indicate if project is externally funded#319
Open
QuanMPhm wants to merge 1 commit into
Open
Added Boolean fied to indicate if project is externally funded#319QuanMPhm wants to merge 1 commit into
QuanMPhm wants to merge 1 commit into
Conversation
knikolla
requested changes
Jun 9, 2026
|
|
||
| PROJECT_ATTRIBUTES = [ | ||
| CloudProjectAttribute( | ||
| name=PROJECT_IS_EXTERNALLY_FUNDED, type="Yes/No", is_changeable=True |
Collaborator
There was a problem hiding this comment.
I don't think this should be is_changeable as it shouldn't be edited by PIs, but set by admins.
Also, I don't think we expose Project Attributes via the API currently, no?
So there would be no way for invoicing to consume this.
Contributor
Author
There was a problem hiding this comment.
Given your comment in this PR, I assume your question here has been answered? Unless I am missing something else?
Contributor
Author
There was a problem hiding this comment.
I have set is_changeable to False
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #320. As part of allowing NERC projects to indicate if they are externally funded.