Deepen query projection boundaries and remove test-only engine seams#32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Projection.Snapshotfact escape and the single-implementation formatter interface while preservingBuildFormatter.add-hugo-github-pages-siteadd-packages-factdeepen-discovery-input-surfacefix-linux-dhcp-lease-interface-matchoptimize-bsd-disks-probeWhy
Query semantics already belonged to
Projection, but raw resolved facts still crossed the Snapshot-to-CLI boundary and caused presentation rules to be rebuilt. Separately, ten helpers existed in production files solely for tests, allowing tests to bypass the real coordination paths.This finishes those ownership boundaries without changing Facts behavior and finalizes the already implemented OpenSpec improvements. The toolchain patch keeps CI and Lima builds on the first Go 1.26 release containing the
crypto/tlsfix.Impact
Behavior-preserving internal refactor and toolchain security update:
Checks
go test ./...go test -race . ./internal/engine ./internal/appgo vet ./...go tool govulncheck ./...make build