fix(ci): skip security scan on forks to avoid SARIF upload permission error#10323
Open
ghshhf wants to merge 2 commits into
Open
fix(ci): skip security scan on forks to avoid SARIF upload permission error#10323ghshhf wants to merge 2 commits into
ghshhf wants to merge 2 commits into
Conversation
…altime ephemeral key/分布式缓存 - A1: NodeConfig 结构体 + discoveryTunnels 全节点快照 + ReplaceNodes - A2: XMLToolCallFormat 三字段扩展 + ParseMsgWithXMLToolCalls reasoning 支持 - A3: RealtimeSessions 60s HMAC 短期令牌 + transcription 模型可选 + any-to-any 判定 - A4: replicaCache 分布式缓存层，减少重复 FindAndLockNodeWithModel DB 调用 - 附带: metrics/monitoring/worker/templates/mcp httpapi 相关完善
… error The Security Scan workflow was failing on fork PRs because the workflow does not have permission to upload SARIF files to the GitHub Security tab when running from a fork. This change adds '!github.repository.fork' checks to all steps to prevent the workflow from running on fork repositories. This fix should be applied to the main repository so that all forks inherit the correct configuration. Fixes mudler#10322, mudler#10318, mudler#10320, mudler#10321
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Security Scan workflow (
secscan.yaml) was failing on fork PRs because the workflow does not have permission to upload SARIF files to the GitHub Security tab when running from a fork.This PR adds
&& !github.repository.forkchecks to all steps in the Security Scan workflow to prevent it from running on fork repositories.Changes
.github/workflows/secscan.yaml:!github.repository.forkcondition to all stepsTesting
Related Issues
Fixes CI failures on fork PRs (e.g., #10322, #10318, #10320, #10321)