Fix type safety issues reported by Mago static analyzer

.github/workflows/mago.yml

@@ -19,7 +19,7 @@ jobs:
         uses: ./.github/actions/setup-php
 
       - name: Install Mago
-        run: composer config --no-plugins allow-plugins.carthage-software/mago true; composer require --dev carthage-software/mago:1.9.1
+        run: composer config --no-plugins allow-plugins.carthage-software/mago true; composer require --dev carthage-software/mago:1.42.0
 
       - name: Run Mago
         run: ./vendor/bin/mago --config .mago/mago.toml analyze

src/Supporting/CommunicationProvider.php

@@ -800,11 +800,11 @@
             $request = $this->justifyRequest($request);
         }
         $ch = $this->_createCurlHandle($url);
         curl_setopt($ch, CURLOPT_VERBOSE, 0);
         curl_setopt($ch, CURLOPT_HEADER, 1);
         curl_setopt($ch, CURLOPT_HTTP_VERSION, CURL_HTTP_VERSION_1_1);
         if ($methodLower == 'post') {
             curl_setopt($ch, CURLOPT_POST, 1);
         } elseif (in_array($methodLower, ['put', 'patch', 'delete', 'get'], true)) {
             curl_setopt($ch, CURLOPT_CUSTOMREQUEST, strtoupper($methodLower));
         }
@@ -1109,18 +1109,19 @@
         curl_setopt($ch, CURLOPT_SSLVERSION, CURL_SSLVERSION_DEFAULT);
         if ($this->isCertValidating) {
             curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 2);
             curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 1);
             /* Use the OS native certificate authorities, if possible.
             This fixes SSL validation errors if `php.ini` doesn't have [curl] `curl.cainfo`,
             set properly of if this PEM file isn't up to date.
             Better rely on the OS certificate authorities, which is maintained automatically. */
+            $curlVersion = curl_version();
             if (defined('CURLSSLOPT_NATIVE_CA')
-                && version_compare(curl_version()['version'], '7.71', '>=')) {
+                && is_array($curlVersion) && version_compare($curlVersion['version'], '7.71', '>=')) {
                 curl_setopt($ch, CURLOPT_SSL_OPTIONS, CURLSSLOPT_NATIVE_CA);
             }
         } else {
             curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0);
             curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0);
         }
         if (!is_null($this->timeout)) {
             curl_setopt($ch, CURLOPT_TIMEOUT, $this->timeout);

src/Supporting/FileMakerRelation.php

@@ -61,7 +61,7 @@ class FileMakerRelation implements Iterator
     /**
      * FileMakerRelation constructor.
      *
-     * @param array<object> $responseData
+     * @param array|object $responseData
      * @param object|array|null $infoData
      * @param string $result
      * @param int $errorCode
@@ -263,15 +263,16 @@ public function getFieldNames(): array
     private function getNumberedRecord(int $num): ?FileMakerRelation
     {
         $value = null;
-        if (isset($this->data[$num])) {
+        $data = $this->data;
+        if (is_array($data) && isset($data[$num])) {
             $tmpInfo = $this->getDataInfo();
             $dataInfo = null;
             if (is_object($tmpInfo)) {
                 $dataInfo = clone $tmpInfo;
                 $dataInfo->returnedCount = 1;
             }
             $value = new FileMakerRelation(
-                $this->data[$num], $dataInfo, ($this->result == "PORTAL") ? "PORTALRECORD" : "RECORD",
+                $data[$num], $dataInfo, ($this->result == "PORTAL") ? "PORTALRECORD" : "RECORD",
                 $this->errorCode, $this->portalName, $this->restAPI);
         }
         return $value;
@@ -542,7 +543,8 @@ public function current(): ?FileMakerRelation
         switch ($this->result) {
             case "OK":
             case "PORTAL":
-                if (isset($this->data[$this->pointer])) {
+                $data = $this->data;
+                if (is_array($data) && isset($data[$this->pointer])) {
                     $tmpInfo = $this->getDataInfo();
                     $dataInfo = null;
                     if (is_object($tmpInfo)) {
@@ -551,7 +553,7 @@ public function current(): ?FileMakerRelation
                     }
                     $result = ($this->result == "PORTAL") ? "PORTALRECORD" : "RECORD";
                     $portalName = $this->portalName;
-                    $value = new FileMakerRelation($this->data[$this->pointer], $dataInfo, $result,
+                    $value = new FileMakerRelation($data[$this->pointer], $dataInfo, $result,
                         $this->errorCode, $portalName, $this->restAPI);
                 }
                 break;