Conversation
Co-authored-by: Stephan Lachnit <stephanlachnit@debian.org>
| "-L\${libdir}" | ||
| ) | ||
| SET(PKG_CONFIG_CFLAGS | ||
| "-I\${includedir}" |
There was a problem hiding this comment.
This is incomplete, since this misses the compilation flags. This is actually a bit tricky and why I never went further.
The obvious ones are the target compile option (MSGPACK_USE_X3_PARSE needs fixing since it is set via CMAKE_CXX_FLAGS), the more tricky one is that you actually also needs to handle the Boost deps here.
There are two options:
- export all the Boost flags to the .pc file (if there are any, would have to be checked)
- never enable Boost (not nice since it breaks common workflows)
I would also move the default -I and -L flags directly in the pkg-config file as well, since they are static anyway and really only clutter the CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows msgpack installations to be detected via pkg-config
(cc) @stephanlachnit