test(controller): add failing repro for setZoom-before-start race#3908
Open
Jakef14 wants to merge 1 commit into
Open
test(controller): add failing repro for setZoom-before-start race#3908Jakef14 wants to merge 1 commit into
Jakef14 wants to merge 1 commit into
Conversation
`useZoomUpdater` (src/hooks/internal/useZoomUpdater.ts:16) fires controller.setZoom synchronously on the <Camera> component's first mount, before the consumer's `isActive` toggle has caused the session to start. The returned promise is discarded, so on Android the CameraX `OperationCanceledException: Camera is not active` rejection surfaces as an Unhandled Promise Rejection that consumers cannot intercept. <Camera onError> only receives CameraRuntimeError instances. This adds a failing harness test that reproduces the timing imperatively: configure() the session, then call setZoom before start() — the moment useZoomUpdater hits today.
|
@JakeF14-SN is attempting to deploy a commit to the Margelo Team on Vercel. A member of the Team first needs to authorize it. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
useZoomUpdater(src/hooks/internal/useZoomUpdater.ts:16) fires controller.setZoom synchronously on the component's first mount, before the consumer'sisActivetoggle has caused the session to start. The returned promise is discarded, so on Android the CameraXOperationCanceledException: Camera is not activerejection surfaces as an Unhandled Promise Rejection that consumers cannot intercept. only receives CameraRuntimeError instances.This adds a failing harness test that reproduces the timing imperatively: configure() the session, then call setZoom before start() — the moment useZoomUpdater hits today.