[RFC] mp.input: allow clients to override console.lua script-opts#17469
[RFC] mp.input: allow clients to override console.lua script-opts#17469CogentRedTester wants to merge 1 commit intompv-player:masterfrom
Conversation
CogentRedTester
force-pushed
the
mp.input/console-opt-overrides
branch
2 times, most recently
from
72e865f to
75afe9e
Compare
|
Ref. #16138 I'm not sure if it's desirable to override the user preferences like the font size though? |
There are definitely some preferences that are less useful to override, but with the metatable implementation, it would require more code to support a limited subset than to support them all. Or are you referring to the fact that some options may have accessibility reasons for users to override? I can see that argument, but I don't think the solution is to ban changes to some options as some scripts may have legitimate reasons to change them. I would prefer instead to encourage those scripts to expose their own script-opts to change their own defaults. It would not be difficult to add a (non-overridable) script-opt that allows users to provide a list of script opts that cannot be shadowed, but I'm not convinced its worth the extra complexity.
Regarding the solution in the linked issue, overriding script-opts manually in the |
|
Yeah scripts can expose their own script-opts. That issue made me wonder, is your use case to center the input? If so it's probably better to add a dedicated option. Centering totally breaks log and completions but it's fine if you don't use those, though it's not clear how wide the input line should be. |
|
I hadn't considered centering actually, I was thinking more things like changing colours to match the colour scheme of the script, changing borders/padding/gaps based on how many select items a script expects to have, or changing Edit: and of course border/background/font-size styling to make the input request look visually like the other elements a script is drawing on the screen |
|
Yeah that's fair. We can actually use this in select.lua to make history search exact by default. I would suggest not mentioning REPL since that's just a leftover of the original name of the script. I removed most references in 9551de6 but apparently I missed my own at the start of the Since we have several |
CogentRedTester
force-pushed
the
mp.input/console-opt-overrides
branch
2 times, most recently
from
0150833 to
d24f17d
Compare
|
I have replaced the word |
|
This PR does create some overlap between Another option is not to have a |
This commit allows a table of script-opt overrides to be passed to `mp.input.get()` and `mp.input.select()`, which console.lua will use instead of the its own. To minimise required changes, metatables are used to allow console.lua to seamlessly fall back on the original script-opts if the client does not provide an override. To prevent exceptions, the incoming opts must be of the same type.
CogentRedTester
force-pushed
the
mp.input/console-opt-overrides
branch
from
d24f17d to
9646411
Compare
|
Added a note to the |
|
I don't think any option overlaps so far. script-opts are for global user preferences while mp.input fields only make sense for individual requests. |
2 participants
Currently, all input requests are styled the same no matter the source of the request. Users can change style settings using script-opts, but these changes will still apply to requests from all clients. The problem with this approach, is that not all scripts request the same kind of input, so not all will necessarily benefit from the same kind of styling, and some scripts which draw their own UI elements may want console.lua styling to better match their own.
This commit allows a table of script-opt overrides to be passed to
mp.input.get()andmp.input.select()under theconsole_opt_overrideskey, which console.lua will use instead of the its own. To minimise required changes, metatables are used to allow console.lua to seamlessly fall back on the original script-opts if the client does not provide an override. I have also required that incoming opts have the same type as the existing script-opts, which should prevent any crashes caused by mismatched types.From looking through the code, I don't believe there are any stateful or cached values based on opts that need to be specially updated, the opts appear to be re-queried any time the console is rendered or a keybind is pressed and any crashes/bugs that might be caused by invalid inputs of the right type would presumably also happen if the user sets script-opts normally. However, I would appreciate a second opinion from someone familiar with console.lua.