ci/macos: don't set MACOSX_DEPLOYMENT_TARGET to empty string#17331
ci/macos: don't set MACOSX_DEPLOYMENT_TARGET to empty string#17331kasper93 wants to merge 1 commit intompv-player:masterfrom
Conversation
Fixes: error: failed to parse deployment target specified in MACOSX_DEPLOYMENT_TARGET: cannot parse integer from empty string
|
this seems to be a problem with rust and how they parse the version string from that env variable. the current build tools/pipeline don't have that problem and i would say an empty string could be considered a valid input (same as unset) or at least something that could be handled gracefully. i think this should rather be fixed by rust, only be merged if we actually use rust and only as a (temporary) workaround imo. as context from irc: error run: https://github.com/mpv-player/mpv/actions/runs/21195313096/job/60969880968 |
|
What is the value of setting this variable to empty string? |
|
it's cleaner and avoids an unnecessary condition atm. what is the value of an unnecessary fix? |
It fixes building with rustc on CI. |
we don't use rustc atm, so it doesn't fix anything. |
2 participants
Fixes:
error: failed to parse deployment target specified in MACOSX_DEPLOYMENT_TARGET: cannot parse integer from empty string