Support load code review skills from URLs on demand#6036
Draft
suhaibmujahid wants to merge 2 commits into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds on-demand loading of code review “skills” from remote URLs so the review agent can fetch optional guidance only when needed.
Changes:
- Adds a
Skilldata model with lazy HTTP loading, frontmatter stripping, and caching. - Adds a LangChain
load_skilltool and wires it intoCodeReviewTool. - Adds tests for frontmatter stripping, skill loading/caching, tool errors, and tool descriptions.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
bugbug/tools/code_review/data_types.py |
Defines skill loading, caching, and frontmatter removal. |
bugbug/tools/code_review/langchain_tools.py |
Adds the load_skill LangChain tool. |
bugbug/tools/code_review/agent.py |
Registers the skill-loading tool when skills are configured. |
bugbug/tools/code_review/prompts.py |
Adds the review skill catalog placeholder. |
tests/test_code_review.py |
Adds tests for the new skill-loading functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d39328f to
c45d0fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow lazy loading skills from URLs and use it when needed.