Remove sync15's "standalone-sync" feature, remove UDL for a single enum.#7152
Merged
mhammond merged 1 commit intomozilla:mainfrom Apr 8, 2026
Merged
Remove sync15's "standalone-sync" feature, remove UDL for a single enum.#7152mhammond merged 1 commit intomozilla:mainfrom
mhammond merged 1 commit intomozilla:mainfrom
Conversation
mhammond
force-pushed
the
push-vsxynlytzvoz
branch
from
d755837 to
3a4ab53
Compare
Member
Author
|
oops, can't do 2024 yet due to our msr. |
mhammond
force-pushed
the
push-vsxynlytzvoz
branch
2 times, most recently
from
39c2c26 to
4086c0c
Compare
mhammond
force-pushed
the
push-vsxynlytzvoz
branch
from
4086c0c to
504440f
Compare
mhammond
force-pushed
the
push-vsxynlytzvoz
branch
from
504440f to
cd1c777
Compare
bendk
approved these changes
Feb 25, 2026
Contributor
bendk
left a comment
bendk
left a comment
There was a problem hiding this comment.
Looks great to me, I love the deletions.
| return std::cmp::max(time, cur_best); | ||
| } | ||
| if let Err(e) = r | ||
| && let Some(time) = e.get_backoff() |
Contributor
There was a problem hiding this comment.
Nice! I'm excited to start using multi-term if lets.
mhammond
force-pushed
the
push-vsxynlytzvoz
branch
2 times, most recently
from
68f6f5e to
d62dada
Compare
Remove the udl for sync15 - it just had one enum. "Bonus" update of the crate to 2024, which is a bigger diff than I anticipated. Seems ok though?
mhammond
force-pushed
the
push-vsxynlytzvoz
branch
from
d62dada to
2a108a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the udl for sync15 - it just had one enum.
"Bonus" update of the crate to 2024, which is a bigger diff than I anticipated. Seems ok though?