Duplicate scanner results for rollbacked versions#24962
Merged
eviljeff merged 2 commits intoMay 29, 2026
Merged
Conversation
diox
requested changes
May 29, 2026
Member
diox
left a comment
There was a problem hiding this comment.
Unfortunately doesn't copy over matched_rules for the results, which is a problem.
diox
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#16152
Description
Duplicates scanner results linked to a version when we're rolling it back
Context
I tried to make AbstractScannerResult.duplicate as generic as possible, not knowing what future fields could be added to the models. (I started writing a more generic function that would accept any arbitrary fields as overrides - not just version - but it ended up getting complicated due to foreign keys and it really wasn't worth it given our current use case)
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.