Fix remaining lint issues and remove the lint baseline#4156
Merged
jonalmeida merged 4 commits intomasterfrom Mar 2, 2026
Merged
Fix remaining lint issues and remove the lint baseline#4156jonalmeida merged 4 commits intomasterfrom
jonalmeida merged 4 commits intomasterfrom
Conversation
Add contentDescription attribute to the FloatingActionButton in fragment_browser.xml and a corresponding string resource for accessibility (screen reader) support.
Replace the deprecated onBackPressed() override with an OnBackPressedCallback registered in onCreate, giving UserInteractionHandler fragments first chance to handle back presses before falling back to the default dispatcher behavior.
Rename mipmap-anydpi-v26 to mipmap-anydpi since minSdkVersion is 26, making the v26 qualifier redundant. Add a <monochrome> tag to both adaptive icon XMLs using the existing foreground drawable, enabling themed app icon support on Android 13+.
jonalmeida
approved these changes
Mar 2, 2026
| <adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
| <background android:drawable="@mipmap/ic_icon_background"/> | ||
| <foreground android:drawable="@drawable/ic_icon_foreground"/> | ||
| <monochrome android:drawable="@drawable/ic_icon_foreground"/> |
Collaborator
There was a problem hiding this comment.
Tragic. I might try to sketch up a monochrome icon at some point. 😄
Merge Queue StatusRule:
This pull request spent 39 minutes 42 seconds in the queue, including 39 minutes 16 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.