Skip to content

fix: fix caret error on incorrect final word (@Positiveoo1) #8191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Positiveoo1 wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −3
Open

fix: fix caret error on incorrect final word (@Positiveoo1) #8191

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce43aa
fix caret error on incorrect final word
Positiveoo1 Jul 3, 2026
e461a91
fix: address caret review
Positiveoo1 Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions frontend/src/ts/elements/caret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,14 +395,21 @@ export class Caret {
isDirectionReversed: boolean;
}): { left: number; top: number; width: number } {
const letters = options.word?.qsa("letter");
let letter;
if (!letters?.length || !(letter = letters[options.letterIndex])) {
// maybe we should return null here instead of throwing

if (letters.length === 0) {
throw new Error(
"Caret getTargetPositionAndWidth: no letters found in word",
);
}

let letter = letters[options.letterIndex] ?? letters[letters.length - 1];

if (!letter) {
throw new Error(
`Caret getTargetPositionAndWidth: letter not found for index ${options.letterIndex}`,
);
}

if (caretDebug) {
if (this.id === "paceCaret") {
for (const l of document.querySelectorAll(".word letter")) {
Expand Down
Loading