fix(tests): handle unknown .jsx extension for TanStack solid dependencies (@ennajari)

[ennajari]

Fixes #7801

@tanstack/solid-* packages ship .jsx source files that Node.js cannot load without a JSX transform.

Fix: Add ssr.noExternal: ["@solidjs/meta", /@tanstack\/solid-.*/] to all three test projects (unit, jsdom, jsx). This forces Vite to bundle and transform them through vite-plugin-solid.

Test plan

• pnpm vitest run completes without "Unknown file extension" errors
• Tests importing @tanstack/solid-* packages run correctly

[byseif21]

hi @ennajari , did you test that really? cuz that doesn't seem like the full fix

[byseif21]

btw @fehmer has assigned it to himself, so he may want to look at it himself, i think you should have asked before the PR

[fehmer]

i don't mind somebody else fixing it, I haven't started working on it yet.

@byseif21 could you provide the test-case to reproduce the problem?

[github-actions]

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

[byseif21]

@byseif21 could you provide the test-case to reproduce the problem?

sure, here

import { test, expect } from "vitest";
import { createHotkey } from "@tanstack/solid-hotkeys";

test("triggers jsx crash", () => {
  expect(createHotkey).toBeDefined();
});

try as a new test file (e.g repro.spec.ts in frontend/__tests__/), running it should fail in master

[fehmer]

thanks @byseif21 ,

shouldn't the test be named repo.spec.tsx? Do we need to add the fix to all three kinds of test or only the jsxtest?

Just adding the regex to the jsxtests works for me:

  ssr: {
      noExternal: ["@solidjs/meta", /@tanstack\/solid-.*/],
    },

[byseif21]

shouldn't the test be named repo.spec.tsx? Do we need to add the fix to all three kinds of test or only the jsxtest?

hmm the thing is, wouldn't naming tests as .tsx be a bit inconsistent if they don't actually have UI components? I thought it was better to keep logic tests as .ts (like the ones in frontend/__tests__/) and only use .tsx for components?

tests like for the hotkeys one when we add it, it will be only logic test and if it'll be as ts as i think, importing e.g @tanstack/solid-hotkeys or anything that use it, makes it fail

[ennajari]

Agreed with @byseif21. The repro imports from @tanstack/solid-hotkeys in a .spec.ts file, which matches the unit project (__tests__/**/*.spec.ts) — not the jsx one (.spec.tsx). Applying noExternal only to the jsx project would leave this failure path open.

Current PR already applies the regex to all three projects via a shared constant, so the repro should pass as-is. Happy to narrow it down if you prefer a different split.